Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patches on the asv workflows #317

Merged
merged 2 commits into from
Nov 9, 2023
Merged

Patches on the asv workflows #317

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
259ae17
Fix asv nightly workflow not finding benchmarks.json
camposandro Nov 8, 2023
6222c33
Allow asv-main to finish when benchmarks fail
camposandro Nov 8, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...oject-template/.github/workflows/{% if include_benchmarks %}asv-main.yml{% endif %}.jinja
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,7 @@ jobs:
fi

- name: Run ASV for the main branch
run: asv run ALL --skip-existing --verbose
run: asv run ALL --skip-existing --verbose || true

- name: Submit new results to the "benchmarks" branch
uses: JamesIves/github-pages-deploy-action@v4
Expand Down
16 changes: 14 additions & 2 deletions ...ct-template/.github/workflows/{% if include_benchmarks %}asv-nightly.yml{% endif %}.jinja
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,9 +46,23 @@ jobs:
python -m pip install --upgrade pip
pip install asv==0.6.1 virtualenv

- name: Configure git
run: |
git config user.name "github-actions[bot]"
git config user.email "41898282+github-actions[bot]@users.noreply.github.com"

- name: Create ASV machine config file
run: asv machine --machine gh-runner --yes

- name: Fetch previous results from the "benchmarks" branch
run: |
if git ls-remote --exit-code origin benchmarks > /dev/null 2>&1; then
git merge origin/benchmarks \
--allow-unrelated-histories \
--no-commit
mv ../_results .
fi

- name: Get nightly dates under comparison
id: nightly-dates
run: |
Expand All @@ -65,13 +79,11 @@ jobs:
run: |
HASH_FILE={% raw %}${{ env.NIGHTLY_HASH_FILE }}{% endraw %}
CURRENT_HASH={% raw %}${{ github.sha }}{% endraw %}

if [ -f $HASH_FILE ]; then
PREV_HASH=$(cat $HASH_FILE)
asv continuous $PREV_HASH $CURRENT_HASH --verbose || true
asv compare $PREV_HASH $CURRENT_HASH --sort ratio --verbose
fi

echo $CURRENT_HASH > $HASH_FILE

- name: Update last nightly hash in cache
Expand Down