Update metric creation to happen only once per store

linkedin · Dec 20, 2024 · 150ca55 · 150ca55
1 parent d4a02d3
commit 150ca55
Showing 1 changed file with 6 additions and 3 deletions.
diff --git a/services/venice-router/src/main/java/com/linkedin/venice/router/MetaDataHandler.java b/services/venice-router/src/main/java/com/linkedin/venice/router/MetaDataHandler.java
@@ -484,9 +484,12 @@ private void handleD2ServiceLookup(ChannelHandlerContext ctx, VenicePathParserHe
     }
 
     // Only create metrics for valid stores
-    String d2DiscoveryMetricName = "venice.router.d2_discovery." + storeName;
-    Sensor d2DiscoverySensor = metricsRepository.sensor(d2DiscoveryMetricName);
-    d2DiscoverySensor.add(d2DiscoveryMetricName + ".request.count", new Count());
+    Sensor d2DiscoverySensor = metricsRepository.sensor("venice.router.d2_discovery." + storeName);
+    String d2DiscoveryRequestCountMetric = "venice.router.d2_discovery." + storeName + ".request.count";
+    // Check if metric already exists before adding
+    if (!metricsRepository.metrics().containsKey(d2DiscoveryRequestCountMetric)) {
+      d2DiscoverySensor.add(d2DiscoveryRequestCountMetric, new Count());
+    }
     d2DiscoverySensor.record();
 
     String clusterName = config.get().getCluster();