Further split services unit tests into Routers/Servers/Controllers #1399
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 8 commits
December 16, 2024 10:24
sushantmane
reviewed
Dec 17, 2024
...a-vinci-client/src/test/java/com/linkedin/davinci/kafka/consumer/StoreIngestionTaskTest.java
Show resolved
Hide resolved
sushantmane
approved these changes
Dec 17, 2024
sushantmane
requested changes
Dec 17, 2024
There was a problem hiding this comment.
can you merge https://github.com/linkedin/venice/pull/1334/files in this PR and close https://github.com/linkedin/venice/pull/1334/files?
good catch! I forgot to merge that |
sushantmane
reviewed
Dec 17, 2024
sushantmane
approved these changes
Dec 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Further split services unit tests into Routers/Servers/Controllers
The client module contains da-vinci-client which contains most of the server code. This PR splits the unit tests into more categories based on the venice components like router/server/controller etc which should improve total UT CI runtime further from 28 mins to 12mins. Also fixed the some flakiness in SIT tests for jdk8.
How was this PR tested?
CI
Does this PR introduce any user-facing changes?