Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Further split services unit tests into Routers/Servers/Controllers #1399

Merged
merged 10 commits into from
Dec 17, 2024
Merged

Further split services unit tests into Routers/Servers/Controllers #1399

Show file tree
Hide file tree
Changes from 8 commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
8a6e36b
Further split unit tests in router/server/controller
Dec 16, 2024
122cd7c
Further split unit tests in router/server/controller
Dec 16, 2024
3c8ae65
Further split unit tests in router/server/controller
Dec 16, 2024
a2d85b2
Further split unit tests in router/server/controller
Dec 16, 2024
486ffd9
Further split unit tests in router/server/controller
Dec 16, 2024
d75f1dc
Further split unit tests in router/server/controller
Dec 16, 2024
ce47b61
Further split unit tests in router/server/controller
Dec 16, 2024
2e12773
Further split unit tests in router/server/controller
Dec 16, 2024
c22ab1c
Further split unit tests in router/server/controller
Dec 17, 2024
9903616
Further split unit tests in router/server/controller
Dec 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .github/workflows/UnitTests-core.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,7 @@ jobs:
rsync -R --files-from=artifacts.list . ${{ inputs.artifact_suffix }}-artifacts
tar -zcvf ${{ inputs.artifact_suffix }}-jdk${{ matrix.jdk }}-logs.tar.gz ${{ inputs.artifact_suffix }}-artifacts
- name: Publish Test Report
continue-on-error: true
env:
NODE_OPTIONS: "--max_old_space_size=8192"
uses: mikepenz/action-junit-report@v3
Expand Down
40 changes: 28 additions & 12 deletions .github/workflows/VeniceCI-StaticAnalysisAndUnitTests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,8 +65,7 @@ jobs:
uses: ./.github/workflows/UnitTests-core.yml
with:
artifact_suffix: clients
arg: :clients:da-vinci-client:jacocoTestCoverageVerification :clients:da-vinci-client:diffCoverage
:clients:venice-admin-tool:jacocoTestCoverageVerification :clients:venice-admin-tool:diffCoverage
arg: :clients:venice-admin-tool:jacocoTestCoverageVerification :clients:venice-admin-tool:diffCoverage
:clients:venice-producer:jacocoTestCoverageVerification :clients:venice-producer:diffCoverage
:integrations:venice-pulsar:jacocoTestCoverageVerification :integrations:venice-pulsar:diffCoverage
:clients:venice-client:jacocoTestCoverageVerification :clients:venice-client:diffCoverage
Expand All @@ -84,19 +83,28 @@ jobs:
:internal:venice-test-common:jacocoTestCoverageVerification :internal:venice-test-common:diffCoverage --continue


Services:
uses: ./.github/workflows/UnitTests-core.yml
with:
artifact_suffix: services
arg: :services:venice-controller:jacocoTestCoverageVerification :services:venice-controller:diffCoverage
:services:venice-router:jacocoTestCoverageVerification :services:venice-router:diffCoverage
:services:venice-server:jacocoTestCoverageVerification :services:venice-server:diffCoverage --continue
Controller:
uses: ./.github/workflows/UnitTests-core.yml
with:
artifact_suffix: controller
arg: :services:venice-controller:jacocoTestCoverageVerification :services:venice-controller:diffCoverage --continue
Server:
uses: ./.github/workflows/UnitTests-core.yml
with:
artifact_suffix: server
arg: :clients:da-vinci-client:jacocoTestCoverageVerification :clients:da-vinci-client:diffCoverage
:services:venice-server:jacocoTestCoverageVerification :services:venice-server:diffCoverage --continue
Router:
uses: ./.github/workflows/UnitTests-core.yml
with:
artifact_suffix: router
arg: :services:venice-router:jacocoTestCoverageVerification :services:venice-router:diffCoverage --continue

StaticAnalysisAndUnitTestsCompletionCheck:
strategy:
fail-fast: false
runs-on: ubuntu-latest
needs: [ValidateGradleWrapper, StaticAnalysis, Clients, Internal, Services]
needs: [ValidateGradleWrapper, StaticAnalysis, Clients, Internal, Controller, Server, Router]
timeout-minutes: 120
if: success() || failure() # Always run this job, regardless of previous job status
steps:
Expand All @@ -118,8 +126,16 @@ jobs:
echo "Internal module unit tests failed."
exit 1
fi
if [ "${{ needs.Services.result }}" != "success" ]; then
echo "Services module unit tests failed."
if [ "${{ needs.Controller.result }}" != "success" ]; then
echo "Controller module unit tests failed."
exit 1
fi
if [ "${{ needs.Server.result }}" != "success" ]; then
echo "Server module unit tests failed."
exit 1
fi
if [ "${{ needs.Router.result }}" != "success" ]; then
echo "Router module unit tests failed."
exit 1
fi
# If all previous jobs were successful, proceed
Expand Down
1 change: 1 addition & 0 deletions ...inci-client/src/test/java/com/linkedin/davinci/kafka/consumer/StoreIngestionTaskTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2323,6 +2323,7 @@ public void testDataValidationCheckPointing(SortedInput sortedInput, AAConfig aa
});

StoreIngestionTaskTestConfig config = new StoreIngestionTaskTestConfig(relevantPartitions, () -> {
Utils.sleep(1000);
majisourav99 marked this conversation as resolved.
Show resolved Hide resolved
// Verify that all partitions reported success.
maxOffsetPerPartition.entrySet()
.stream()
Expand Down
Loading