Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Bring back polkit authentication agent (and patch it...) #10177

Closed
wants to merge 14 commits into from
Closed

[WIP] Bring back polkit authentication agent (and patch it...) #10177

wants to merge 14 commits into from

Conversation

ItzSwirlz
Copy link
Contributor

@ItzSwirlz ItzSwirlz commented Jun 25, 2021

This was removed in 2.0.8 and left us to rely on policykit-1-gnome by
other applications such as pkexec, which is unmaintained (last commit
was in 2013).

Refer to #10172


Ever since it was removed, GNOME patched a bunch of other stuff and crashes that I'll backport here. Then get the JS stuff working

  • Bring back the files
  • Backport patches (patch JS files)
  • Work the JS UI
  • Why does the build complain about redefining the POLKIT_I_KNOW_API_IS_SUBJECT_TO_CHANGE?
  • Final cleanups (debian packaging, pkexec, etc.)

This was removed in 2.0.8 and left us to rely on policykit-1-gnome by 
other applications such as pkexec, which is unmaintained (last commit 
was in 2013).

Refer to #10172
@ItzSwirlz ItzSwirlz marked this pull request as draft June 25, 2021 14:36
@ItzSwirlz ItzSwirlz changed the title Bring back polkit authentication agent (and patch it...) [WIP] Bring back polkit authentication agent (and patch it...) Jun 25, 2021
@Fantu
Copy link
Contributor

Fantu commented Jun 25, 2021

@ItzSwirlz thanks for starting do this, even if probably was better wait other comments about the choice (in #10172).
If you want do a fast test you should remove policykit-1-gnome from debian/control of cinnamon and cinnamon-control-center and remove it from the test system.

Removed in 72b406c - makes us rely on policykit-1-gnome which is deprecated.

Ref: #10172
@ItzSwirlz
Copy link
Contributor Author

ItzSwirlz commented Jun 25, 2021

And that leaves us with this ugly masterpiece. This is good-it means automatically pkexec uses our authentication agent. Now it's just the UI tuning. I'm pretty new to this stuff, if anyone wants to take a shot at it, go ahead but I'll do what I can to get it to what it was like previously.

But I don't want to make any UI changes-I think this is a great opportunity for all the devs to come together to choose and design what the final polkit UI should look like in cinnamon.
Screenshot from 2021-06-25 17-21-58

@ItzSwirlz
Copy link
Contributor Author

ItzSwirlz commented Jul 3, 2021

Skipped patch https://github.com/GNOME/gnome-shell/commits/master?after=ee1db9ba0a111ccb340bcf3905891684c5731f38+69&branch=master&path%5B%5D=js&path%5B%5D=ui&path%5B%5D=components&path%5B%5D=polkitAgent.js because I couldn't find us having a this.placeSpinner. Not sure how we do on that so I left it.

Everything here is basically large patches I don't want to risk.

This reverts commit c08a712.

This also reverts the setbuttons commit, since we don't have an
addbuttons function

Plus, remove policykit-1-gnome from d/control
@Fantu
Copy link
Contributor

Fantu commented Jul 3, 2021

@ItzSwirlz keep attention to js, don't show warning/error on build but on runtime, years ago when I used on web programming was also more difficult to debug that many other languages that is used.
Also check better when you porting patch from gnome-shell, especially when many years have passed from fork and many things have changed, all the code should always be checked well, even with patches that apply correctly with cherry-pick or minimal manual changes.
In these weeks I have very little time and I can't help you with this task.

@mtwebster
Copy link
Member

Honestly I'm not sure we're interested in this.

  • what will our fallback mode use? I don't want something that's inaccessible in certain situations.
  • one reason we got rid of this originally was we felt the less the cinnamon process had to do, the more stable it would be. This is still true.

If we have no choice but to take up gnome-polkit ourselves, so be it. We'll have to consider it.

@ItzSwirlz
Copy link
Contributor Author

ItzSwirlz commented Jul 3, 2021

If we have no choice but to take up gnome-polkit ourselves, so be it

Use mate-polkit then, shall I close this and create a new PR around porting to mate-polkit?

@Fantu
Copy link
Contributor

Fantu commented Jul 3, 2021

@mtwebster @ItzSwirlz I think is better continue to discussion about the choice on #10172 so also other peoples subscribed can see these message

@ItzSwirlz
Copy link
Contributor Author

We will be going cross-DE

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants