-
Notifications
You must be signed in to change notification settings - Fork 746
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Bring back polkit authentication agent (and patch it...) #10177
Conversation
This was removed in 2.0.8 and left us to rely on policykit-1-gnome by other applications such as pkexec, which is unmaintained (last commit was in 2013). Refer to #10172
@ItzSwirlz thanks for starting do this, even if probably was better wait other comments about the choice (in #10172). |
Fixes an issue with root allowing popup after authenticating GNOME/gnome-shell@4231c87#diff-13607599fcef0f01017ca09fe932cd62e5d9a64d444a3e2cf87ae04c3648122d
Skipped patch https://github.com/GNOME/gnome-shell/commits/master?after=ee1db9ba0a111ccb340bcf3905891684c5731f38+69&branch=master&path%5B%5D=js&path%5B%5D=ui&path%5B%5D=components&path%5B%5D=polkitAgent.js because I couldn't find us having a this.placeSpinner. Not sure how we do on that so I left it. Everything here is basically large patches I don't want to risk. |
This reverts commit c08a712. This also reverts the setbuttons commit, since we don't have an addbuttons function Plus, remove policykit-1-gnome from d/control
@ItzSwirlz keep attention to js, don't show warning/error on build but on runtime, years ago when I used on web programming was also more difficult to debug that many other languages that is used. |
Honestly I'm not sure we're interested in this.
If we have no choice but to take up gnome-polkit ourselves, so be it. We'll have to consider it. |
Use mate-polkit then, shall I close this and create a new PR around porting to mate-polkit? |
@mtwebster @ItzSwirlz I think is better continue to discussion about the choice on #10172 so also other peoples subscribed can see these message |
We will be going cross-DE |
This was removed in 2.0.8 and left us to rely on policykit-1-gnome by
other applications such as pkexec, which is unmaintained (last commit
was in 2013).
Refer to #10172
Ever since it was removed, GNOME patched a bunch of other stuff and crashes that I'll backport here. Then get the JS stuff working