Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Bring back polkit authentication agent (and patch it...) #10177

Closed
wants to merge 14 commits into from
Closed

[WIP] Bring back polkit authentication agent (and patch it...) #10177

wants to merge 14 commits into from

Commits on Jun 25, 2021

  1. Partially revert commit 4873e7f - bring back polkit authentication agent 

    This was removed in 2.0.8 and left us to rely on policykit-1-gnome by 
other applications such as pkexec, which is unmaintained (last commit 
was in 2013).

Refer to #10172
    @ItzSwirlz
    ItzSwirlz committed Jun 25, 2021
    Configuration menu
    Copy the full SHA
    55366a0 View commit details
    Browse the repository at this point in the history

  2. polkit-authentication-agent: Use generic marshaller 

    GNOME/gnome-shell@b40b199#diff-c39523df28b00e7de962ea59dbb674c6af3b2791531661d9381b375cc4341c74
    @ItzSwirlz
    ItzSwirlz committed Jun 25, 2021
    Configuration menu
    Copy the full SHA
    d4de48a View commit details
    Browse the repository at this point in the history

  3. pokit-agent: fix segfault when we we fail to get the current session 

    see 
GNOME/gnome-shell@b67138b
    @ItzSwirlz
    ItzSwirlz committed Jun 25, 2021
    Configuration menu
    Copy the full SHA
    45a5f58 View commit details
    Browse the repository at this point in the history

  4. polkit-agent: Fix memory leak 

    GNOME/gnome-shell@4e4092f#diff-c39523df28b00e7de962ea59dbb674c6af3b2791531661d9381b375cc4341c74
    @ItzSwirlz
    ItzSwirlz committed Jun 25, 2021
    Configuration menu
    Copy the full SHA
    004252f View commit details
    Browse the repository at this point in the history

  5. polkit-agent: Name the timeout 

    GNOME/gnome-shell@85f811f#diff-c39523df28b00e7de962ea59dbb674c6af3b2791531661d9381b375cc4341c74
    @ItzSwirlz
    ItzSwirlz committed Jun 25, 2021
    Configuration menu
    Copy the full SHA
    94afbd6 View commit details
    Browse the repository at this point in the history

  6. meson: add project arg for polkit-agent

    @ItzSwirlz
    ItzSwirlz committed Jun 25, 2021
    Configuration menu
    Copy the full SHA
    8e42585 View commit details
    Browse the repository at this point in the history

  7. Bring back the JS Polkit Authentication Agent 

    Removed in 72b406c - makes us rely on policykit-1-gnome which is deprecated.

Ref: #10172
    @ItzSwirlz
    ItzSwirlz committed Jun 25, 2021
    Configuration menu
    Copy the full SHA
    7472f01 View commit details
    Browse the repository at this point in the history

Commits on Jul 3, 2021

  1. polkitagent: don't crash if there is no avatar 

    GNOME/gnome-shell@452ac29#diff-13607599fcef0f01017ca09fe932cd62e5d9a64d444a3e2cf87ae04c3648122d
    @ItzSwirlz
    ItzSwirlz committed Jul 3, 2021
    Configuration menu
    Copy the full SHA
    f76e0e3 View commit details
    Browse the repository at this point in the history

  2. polkitagent: Expand password entry to the full width 

    GNOME/gnome-shell@15e1470#diff-13607599fcef0f01017ca09fe932cd62e5d9a64d444a3e2cf87ae04c3648122d
    @ItzSwirlz
    ItzSwirlz committed Jul 3, 2021
    Configuration menu
    Copy the full SHA
    f5b1ae0 View commit details
    Browse the repository at this point in the history

  3. polkitagent: Don't use setbuttons 

    Fixes an issue with root allowing popup after authenticating
GNOME/gnome-shell@4231c87#diff-13607599fcef0f01017ca09fe932cd62e5d9a64d444a3e2cf87ae04c3648122d
    @ItzSwirlz
    ItzSwirlz committed Jul 3, 2021
    Configuration menu
    Copy the full SHA
    c08a712 View commit details
    Browse the repository at this point in the history

  4. polkitAgent: Make sure the entries are insensitive after submission 

    GNOME/gnome-shell@cedd68c
    @ItzSwirlz
    ItzSwirlz committed Jul 3, 2021
    Configuration menu
    Copy the full SHA
    dab90f8 View commit details
    Browse the repository at this point in the history

  5. polkit: use unicode in translatable strings

    @ItzSwirlz
    ItzSwirlz committed Jul 3, 2021
    Configuration menu
    Copy the full SHA
    b4b2f23 View commit details
    Browse the repository at this point in the history

  6. Revert "polkitagent: Don't use setbuttons" and some other stuff 

    This reverts commit c08a712.

This also reverts the setbuttons commit, since we don't have an
addbuttons function

Plus, remove policykit-1-gnome from d/control
    @ItzSwirlz
    ItzSwirlz committed Jul 3, 2021
    Configuration menu
    Copy the full SHA
    cea18b7 View commit details
    Browse the repository at this point in the history

  7. Polkit JS agent: Small linting

    @ItzSwirlz
    ItzSwirlz committed Jul 3, 2021
    Configuration menu
    Copy the full SHA
    d19eded View commit details
    Browse the repository at this point in the history