Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable n_epochs=0 to get the initial embedding #634

Merged
merged 1 commit into from
Mar 30, 2021

Conversation

jondo
Copy link
Contributor

@jondo jondo commented Mar 30, 2021

This extends the range of possible n_epochs values below the current limit 11.

It is e.g. useful to examine the computed spectral embedding. Also, the resulting embedding can then be masked to fix points.

Note that for the new value range, in simplicial_set_embedding the graph data is only thinned with the n_epochs default value, otherwise spectral embedding would give UserWarning: Graph is not fully connected, spectral embedding may not work as expected (or even loop forever for n_epochs=0).

@coveralls
Copy link

Coverage Status

Coverage remained the same at 88.899% when pulling e442bcd on jondo:enable_low_n_epochs into f86c922 on lmcinnes:master.

@lmcinnes
Copy link
Owner

Thanks; this is a useful change -- it is not something I had really looked at, but this enables the functionality you want nicely without doing any harm to anything else.

@lmcinnes lmcinnes merged commit 317ce81 into lmcinnes:master Mar 30, 2021
@jondo
Copy link
Contributor Author

jondo commented Mar 31, 2021

Thank you for merging this!

@jondo jondo deleted the enable_low_n_epochs branch March 31, 2021 07:26
@jondo jondo restored the enable_low_n_epochs branch March 31, 2021 07:27
@jondo jondo deleted the enable_low_n_epochs branch March 31, 2021 07:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants