Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(backport: 11.4 for LS7.x) Fixes an issue where events containing non-unicode strings. #1171

Merged

Conversation

mashhurs
Copy link
Contributor

See origin PR for the details, applying to 11.4.x versions to be available in LS 7.17.x core

@mashhurs mashhurs added the bug label Mar 19, 2024
@mashhurs mashhurs requested a review from yaauie March 19, 2024 17:19
@mashhurs mashhurs self-assigned this Mar 19, 2024
@yaauie
Copy link
Contributor

yaauie commented Mar 19, 2024

I believe we also need to backport #1139 to fix the SSL-related permaloops we are seeing in CI

EDIT: that applies to 11.14.x, not 11.4.x 🤦

@yaauie
Copy link
Contributor

yaauie commented Mar 19, 2024

Ah, it looks like #1137 is relevant backport-to-fix-tests candidate, or the spec/fixtures/test_certs/renew.sh from #1074

@@ -6,7 +6,8 @@ set -ex
cd .ci

if [ "$INTEGRATION" == "true" ]; then
docker-compose up --exit-code-from logstash
# remove the `--attach logstash` if you want to see all logs including elasticsearch container logs
docker-compose up --exit-code-from logstash --attach logstash
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Multiple CI jobs failed with too many logs error. In order to be 100%, attaching only logstash logs to see if there any logic related errors.

@yaauie yaauie changed the title Fixes an issue where events containing non-unicode strings. (backport: 11.4 for LS7.x) Fixes an issue where events containing non-unicode strings. Mar 19, 2024
@mashhurs mashhurs force-pushed the backport-non-utf8-support branch from fe26914 to 84b2a82 Compare March 19, 2024 23:24
@yaauie yaauie merged commit afb9d3e into logstash-plugins:11.4-maintenance Mar 20, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants