Attach only logstash container logs to limit the log fload. #1172
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mashhurs
commented
Mar 19, 2024
| @@ -6,7 +6,8 @@ set -ex | |||
| cd .ci | |||
|
|
|||
| if [ "$INTEGRATION" == "true" ]; then | |||
| docker-compose up --exit-code-from logstash | |||
| # remove the `--attach logstash` if you want to see all logs including elasticsearch container logs | |||
| docker-compose up --exit-code-from logstash --attach logstash | |||
There was a problem hiding this comment.
Some Travis CI jobs failed due to too many logs. In order to be 100% with the changes not breaking anything, limiting the logs excluding elasticsearch container logs.
yaauie
approved these changes
Mar 19, 2024
yaauie
added a commit
to yaauie/logstash-output-elasticsearch
that referenced
this pull request
Mar 19, 2024
mashhurs
commented
Mar 19, 2024
| @@ -48,10 +48,10 @@ if [ "$ELASTIC_STACK_VERSION" ]; then | |||
|
|
|||
| if [ "$INTEGRATION" == "true" ]; then | |||
| docker-compose down | |||
| docker-compose build | |||
| docker-compose build --quiet | |||
There was a problem hiding this comment.
we are getting ~34k log lines with docker-compose build command. Adding --quiet to see if it decreases.
There was a problem hiding this comment.
FYI: now .ci/docker-setup.sh log lines about 20 lines.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for contributing to Logstash! If you haven't already signed our CLA, here's a handy link: https://www.elastic.co/contributor-agreement/