Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attach only logstash container logs to limit the log fload. #1172

Merged
merged 2 commits into from
Mar 19, 2024
Merged

Attach only logstash container logs to limit the log fload. #1172

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
121c7b8
Attach only logstash contianer logs to limit the log floading.
mashhurs Mar 19, 2024
7c11e7a
Add a quite option when building docker, causing 34k log lines.
mashhurs Mar 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion .ci/docker-run.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,8 @@ set -ex
cd .ci

if [ "$INTEGRATION" == "true" ]; then
docker-compose up --exit-code-from logstash
# remove the `--attach logstash` if you want to see all logs including elasticsearch container logs
docker-compose up --exit-code-from logstash --attach logstash
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some Travis CI jobs failed due to too many logs. In order to be 100% with the changes not breaking anything, limiting the logs excluding elasticsearch container logs.

else
docker-compose up --exit-code-from logstash logstash
fi
4 changes: 2 additions & 2 deletions .ci/docker-setup.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,10 +48,10 @@ if [ "$ELASTIC_STACK_VERSION" ]; then

if [ "$INTEGRATION" == "true" ]; then
docker-compose down
docker-compose build
docker-compose build --quiet
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we are getting ~34k log lines with docker-compose build command. Adding --quiet to see if it decreases.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI: now .ci/docker-setup.sh log lines about 20 lines.

else
docker-compose down
docker-compose build logstash
docker-compose build logstash --quiet
fi
else
echo "Please set the ELASTIC_STACK_VERSION environment variable"
Expand Down