DM-45750: Store new-style ephemerides and APDB catalogs in ap_verify data sets #238
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 10, 2024
ebellm
approved these changes
Oct 14, 2024
ap_verify was originally written as a mockup of the process of ingesting and processing new raws. It makes more sense to treat preprocessing datasets as prior inputs, and this also handles the case where preprocessing can't be run in Jenkins.
kfindeisen
force-pushed
the
tickets/DM-45750
branch
from
c5f893d
to
1ebcef3
Compare
kfindeisen
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the preprocessing tasks from
ApVerifypipelines. These datasets are now handled by theap_verifydata set itself, just like other inputs that are available when raws arrive.sconsand/orstack-os-matrix)?ap_verify.pyon at least one of the standard datasets?For changes to metrics, the
print_metricvaluesscript fromlsst.verifywill be useful.