Merge pull request #1201 from luxonis/fix/remote_connection_checks

Add pipeline checks to RemoteConnection's exposePipelineService method
luxonis · Dec 20, 2024 · 9ceab34 · 9ceab34
2 parents f5bd0dd + 62e6139
commit 9ceab34
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 0 deletions.
diff --git a/bindings/python/src/pipeline/PipelineBindings.cpp b/bindings/python/src/pipeline/PipelineBindings.cpp
@@ -258,6 +258,8 @@ void PipelineBindings::bind(pybind11::module& m, void* pCallstack){
                  }
                  p.stop();
              })
+        .def("build", &Pipeline::build)
+        .def("isBuilt", &Pipeline::isBuilt)
         .def("isRunning", &Pipeline::isRunning)
         .def("processTasks", &Pipeline::processTasks, py::arg("waitForTasks") = false, py::arg("timeoutSeconds") = -1.0)
         .def("enableHolisticRecord", &Pipeline::enableHolisticRecord, py::arg("recordConfig"), DOC(dai, Pipeline, enableHolisticRecord))

diff --git a/src/remote_connection/RemoteConnectionImpl.cpp b/src/remote_connection/RemoteConnectionImpl.cpp
@@ -10,6 +10,7 @@
 #include "foxglove/websocket/common.hpp"
 #include "pipeline/datatype/Buffer.hpp"
 #include "pipeline/datatype/ImgAnnotations.hpp"
+#include "utility/ErrorMacros.hpp"
 #include "utility/Logging.hpp"
 #include "utility/ProtoSerializable.hpp"
 #include "utility/Resources.hpp"
@@ -352,6 +353,10 @@ void RemoteConnectionImpl::exposeKeyPressedService() {
 }
 
 void RemoteConnectionImpl::exposePipelineService(const Pipeline& pipeline) {
+    // Make sure pipeline is built so that we can serialize it.
+    // If not built, an error is thrown is case there are host -> device or device -> host connections.
+    DAI_CHECK(pipeline.isBuilt(), "Pipeline is not built. Call Pipeline::build first!");
+
     std::vector<foxglove::ServiceWithoutId> services;
     auto pipelineService = foxglove::ServiceWithoutId();
     pipelineService.name = "pipelineSchema";