Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run inference on the same device as used in the Trainer #121

Merged
merged 7 commits into from
Nov 8, 2024

Conversation

sokovninn
Copy link
Member

This PR includes:

  • Added inference logic to the LuxonisLightningModule
  • Dataset and image folder inference now run on the same device as used in the Trainer
  • Loss is no longer computed during inference

The implementation of video inference has not changed.

@sokovninn sokovninn requested a review from a team as a code owner November 5, 2024 21:29
@sokovninn sokovninn requested review from kozlov721, klemen1999, tersekmatija and conorsim and removed request for a team November 5, 2024 21:29
@github-actions github-actions bot added the enhancement New feature or request label Nov 5, 2024
Copy link
Collaborator

@kozlov721 kozlov721 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@klemen1999 klemen1999 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

codecov bot commented Nov 8, 2024

Codecov Report

Attention: Patch coverage is 97.61905% with 1 line in your changes missing coverage. Please review.

Project coverage is 95.79%. Comparing base (631b905) to head (bab2059).
Report is 8 commits behind head on main.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
luxonis_train/core/utils/infer_utils.py 97.22% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #121      +/-   ##
==========================================
- Coverage   96.31%   95.79%   -0.53%     
==========================================
  Files         147      159      +12     
  Lines        6304     6922     +618     
==========================================
+ Hits         6072     6631     +559     
- Misses        232      291      +59     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@klemen1999 klemen1999 merged commit f845922 into main Nov 8, 2024
8 of 9 checks passed
@klemen1999 klemen1999 deleted the feat/improved-inference branch November 8, 2024 21:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants