Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Id conversion traits #48

Closed
wants to merge 2 commits into from
Closed

Id conversion traits #48

wants to merge 2 commits into from

Conversation

madsmtm
Copy link
Owner

@madsmtm madsmtm commented Oct 28, 2021

Proof-of-concept on fixing the remaining part of #41, identified in #39 (upstream SSheldon/rust-objc-foundation#1).

Another alternative would be to mark Id with the unstable #[fundamental] attribute, see RFC 1023 and tracking issue.

@madsmtm madsmtm added the enhancement New feature or request label Oct 28, 2021
@madsmtm
Copy link
Owner Author

madsmtm commented Oct 28, 2021

I'm not really satisfied with this, vec.into_id() is wayy less readable than NSArray::from_vec(vec), and of course NSArray::from(vec) would have been best.

@madsmtm madsmtm force-pushed the id-conversion-traits branch from 924bd25 to 522f93b Compare November 2, 2021 20:45
@madsmtm madsmtm mentioned this pull request Nov 3, 2021
80 tasks
@madsmtm
Copy link
Owner Author

madsmtm commented Mar 2, 2022

Yeah, these don't really make sense, let's aim for #50 instead.

@madsmtm madsmtm closed this Mar 2, 2022
@madsmtm madsmtm deleted the id-conversion-traits branch March 2, 2022 19:26
@madsmtm madsmtm mentioned this pull request Jan 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant