Make Id #[fundamental]
#50
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
madsmtm
force-pushed
the
id-fundamental
branch
from
116be04 to
050603b
Compare
Closed
This changes the coherence rules to give Id less flexibility in terms of forwards compatibility, but in return allowing downstream crates (like objc2_foundation) to implement From for this type. Requires feature flag unstable-id-fundamental
|
So it turns out that since #150, we can't actually use this feature any more, it prevents us from implementing Hence I'll close this, if we find it to be a big issue we can always just use newtypes, like |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proof-of-concept on fixing the remaining part of #41, identified in #39 (upstream SSheldon/rust-objc-foundation#1). Probably a better alternative than #48.
The
#[fundamental]attribute is unstable, see RFC 1023 and tracking issue, so I won't merge this.