fix(ios): fix install problems on new arch #225
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Nov 6, 2024
mrousavy
pushed a commit
that referenced
this pull request
Nov 7, 2024
* upgrade iOS to RN 0.76.1 * android upgrade to RN 0.76 * fix eslint setup * android fix cmake * fix CI node setup * tests have changed due to updated babel version * fix java version * upgrade yest * fix iOS builds * change checksum of podfile for GH action to re-evaluate * fix iOS builds * fix: fix iOS podspec for new arch (#225) * fix(ios): fix install problems on new arch * compile example app for new arch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RNWC already has a code path for new arch on iOS and on android its already a Turbo Module package, so thats all fine.
For iOS we had to fix the podspec though as otherwise you would get build errors (see here for reference)
based on this PR which should be merged first: