Develop #1039
Open
Develop #1039
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
etojeDenys
suggested changes
Nov 22, 2024
src/scripts/main.js
Outdated
Comment on lines
80
to
106
| if (e.key === 'ArrowRight') { | ||
| // eslint-disable-next-line no-console | ||
| console.log('Right'); | ||
| game.moveRight(); | ||
| renderField(game.state); // Відображаємо оновлене поле після руху | ||
| } | ||
|
|
||
| if (e.key === 'ArrowLeft') { | ||
| // eslint-disable-next-line no-console | ||
| console.log('Left'); | ||
| game.moveLeft(); | ||
| renderField(game.state); // Відображаємо оновлене поле після руху | ||
| } | ||
|
|
||
| if (e.key === 'ArrowUp') { | ||
| // eslint-disable-next-line no-console | ||
| console.log('Up'); | ||
| game.moveUp(); | ||
| renderField(game.state); // Відображаємо оновлене поле після руху | ||
| } | ||
|
|
||
| if (e.key === 'ArrowDown') { | ||
| // eslint-disable-next-line no-console | ||
| console.log('Down'); | ||
| game.moveDown(); | ||
| renderField(game.state); // Відображаємо оновлене поле після руху | ||
| } |
There was a problem hiding this comment.
try to simplify it using the switch case
etojeDenys
suggested changes
Nov 26, 2024
src/modules/Game.class.js
Outdated
| // eslint-disable-next-line no-console | ||
| console.log(initialState); | ||
| console.log(this.initialState); |
src/modules/Game.class.js
Outdated
Comment on lines
152
to
156
| // Об'єднуємо однакові числа, починаючи знизу | ||
| // рухаємось знизу вверх по колонці, не рядку | ||
| // якщо ми бачимо, що цей елемент {і} === {і - 1} | ||
| // тобто дорівнює попередньому елементу, то ми множимо числа на 2 | ||
| // TODO: зробити типу такої логіки з двійкою, але можна винести |
volodymyr-soltys97
suggested changes
Nov 27, 2024
| */ | ||
| constructor(initialState) { | ||
| // TODO: Замінити по індексу числа |
There was a problem hiding this comment.
Remove all comments
Suggested change
| // TODO: Замінити по індексу числа |
|
etojeDenys
suggested changes
Nov 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.