Solution #1452
Solution #1452
Conversation
There was a problem hiding this comment.
Great job on implementing the caching decorator! 🎉 Your code meets all the task requirements and constraints effectively. While the key generation method using str(args) + str(kwargs) works, consider using a tuple of the arguments for a more robust solution in the future. Keep up the good work and continue refining your skills! 😊
✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨
| @@ -1,6 +1,17 @@ | |||
| from typing import Callable | |||
| from typing import Callable, Any | |||
There was a problem hiding this comment.
The import statement is correct, but ensure that the Callable and Any types are used appropriately in the function signatures.
app/main.py
Outdated
| storage = {} | ||
|
|
||
| def inner(*args, **kwargs) -> Any: | ||
| key = str(args) + str(kwargs) |
There was a problem hiding this comment.
The key generation using str(args) + str(kwargs) may not be reliable for all types of arguments, especially if they are not hashable or if their string representation is not unique. Consider using a more robust method to generate keys, such as using a tuple of the arguments.
No description provided.