Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Solution #1452

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Solution #1452

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5310d95
Solution
lozovoyDanil Dec 10, 2024
6042633
Solution updated. Chenged key saving
lozovoyDanil Dec 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 14 additions & 3 deletions app/main.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,17 @@
from typing import Callable
from typing import Callable, Any

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The import statement is correct, but ensure that the Callable and Any types are used appropriately in the function signatures.


def cache(func: Callable) -> Callable:
# Write your code here
pass
storage = {}

def inner(*args, **kwargs) -> Any:
key = str(args) + str(kwargs)
if key in storage:
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The key generation using str(args) + str(kwargs) may not be reliable for all types of arguments, especially if they are not hashable or if their string representation is not unique. Consider using a more robust method to generate keys, such as using a tuple of the arguments.

print("Getting from cache")
return storage[key]
else:
print("Calculating new result")
result = func(*args, **kwargs)
storage[key] = result
return result
return inner
Loading