-
-
Notifications
You must be signed in to change notification settings - Fork 338
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix various bugs in database reflection, connection caching #3245
Conversation
Not sure what's happening with the CI. Tests pass fine on my 4 GB dev server, but exit with 137 (mem usage over limit, I presume) over here. Should not block review @mathemancer. |
Attempting to troubleshoot why CI is failing; a shot in the dark; will revert if doesn't work.
This reverts commit c8523af.
Found that the CI was failing during tests because there was a typo in code that was being called by |
Something is breaking in the CI, might be this, not sure.
This reverts commit db8140d. Revert "Revert change to how port is defined in testing" This reverts commit f62977c. Revert "Redo how default db credentials are obtained" This reverts commit 667d9dc. Revert "Ignore unused parameter" This reverts commit efcd9a7. Revert "Linter fix" This reverts commit cf0653a. Revert "Add test for db.install.install_mathesar" This reverts commit 1518211.
This reverts commit 8167721.
When I made above comment I was under the impression that I knew how to get CI tests to pass, because one of the commits there had its CI tests pass, but that was a false-positive. Now, the CI tests seem to be really passing. Once reviewed, ready for merging. |
Demo code logic was not changed, only some variables renamed and some routines broken out into methods.
We've completely reorganized the way we're going connections and credentials for databases, and this PR isn't really relevant in that context. I'm going to close it, though we may grab some code from it if needed. |
Related to #3230
Noteworthy changes:
db.credentials.DbCredentials
; a way to uniquely identify a connection to a database; improves on how we previously did that by passing around multiple arguments (like hostname, db_name, username etc);DbCredentials
to key the engine cache; before we were incorrectly using the db_name to identify which database a given engine is for: that would break down when you had two databases with the same name (but different host or port);reset_reflection
andmake_sure_initial_reflection_happened
constructs still key database by their name (that's a significant bug);Checklist
Update ixdex.md
).develop
branch of the repositoryvisible errors.
Developer Certificate of Origin
Developer Certificate of Origin