Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added documentation for goal attribution #120

Open
wants to merge 11 commits into
base: 4.x-dev
Choose a base branch
from

Conversation

AltamashShaikh
Copy link
Contributor

Description:

Added documentation for goal attribution
Fixes: #PG-2659.

Review

@AltamashShaikh AltamashShaikh marked this pull request as ready for review March 13, 2023 09:40
Copy link
Contributor

@snake14 snake14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code looks good and I was able to view the documentation for all of the sections in the Campaigns view. I didn't see documentation in all of the places the screenshots show in the Jira issue, but I'm guessing those required PRs in other repos.

@AltamashShaikh
Copy link
Contributor Author

The code looks good and I was able to view the documentation for all of the sections in the Campaigns view. I didn't see documentation in all of the places the screenshots show in the Jira issue, but I'm guessing those required PRs in other repos.

Yes for detail review, you can check this core PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants