Added documentation for goal attribution

Reports/GetContent.php

@@ -19,6 +19,7 @@ protected function init()
         parent::init();
         $this->dimension      = new CampaignContent();
         $this->name           = Piwik::translate('MarketingCampaignsReporting_Contents');
+        $this->documentation  = '<b>' . Piwik::translate('MarketingCampaignsReporting_AttributionTitle') . ':</b> ' . Piwik::translate('MarketingCampaignsReporting_AttributionDocumentation', ['<a href="https://matomo.org/faq/general/faq_106/" rel="noreferrer noopener" target="_blank">', '</a>']);
         $this->hasGoalMetrics = true;
         $this->order          = 5;
 

Reports/GetGroup.php

@@ -19,6 +19,7 @@ protected function init()
         parent::init();
         $this->dimension      = new CampaignGroup();
         $this->name           = Piwik::translate('MarketingCampaignsReporting_Groups');
+        $this->documentation  = '<b>' . Piwik::translate('MarketingCampaignsReporting_AttributionTitle') . ':</b> ' . Piwik::translate('MarketingCampaignsReporting_AttributionDocumentation', ['<a href="https://matomo.org/faq/general/faq_106/" rel="noreferrer noopener" target="_blank">', '</a>']);
         $this->hasGoalMetrics = true;
         $this->order          = 8;
 

Reports/GetId.php

@@ -19,6 +19,7 @@ protected function init()
         parent::init();
         $this->dimension      = new CampaignId();
         $this->name           = Piwik::translate('MarketingCampaignsReporting_CampaignIds');
+        $this->documentation  = '<b>' . Piwik::translate('MarketingCampaignsReporting_AttributionTitle') . ':</b> ' . Piwik::translate('MarketingCampaignsReporting_AttributionDocumentation', ['<a href="https://matomo.org/faq/general/faq_106/" rel="noreferrer noopener" target="_blank">', '</a>']);
         $this->hasGoalMetrics = true;
         $this->order          = 7;
 

Reports/GetKeyword.php

@@ -19,6 +19,7 @@ protected function init()
         parent::init();
         $this->dimension      = new CampaignKeyword();
         $this->name           = Piwik::translate('MarketingCampaignsReporting_Keywords');
+        $this->documentation  = '<b>' . Piwik::translate('MarketingCampaignsReporting_AttributionTitle') . ':</b> ' . Piwik::translate('MarketingCampaignsReporting_AttributionDocumentation', ['<a href="https://matomo.org/faq/general/faq_106/" rel="noreferrer noopener" target="_blank">', '</a>']);
         $this->hasGoalMetrics = true;
         $this->order          = 2;
 

Reports/GetMedium.php

@@ -19,6 +19,7 @@ protected function init()
         parent::init();
         $this->dimension      = new CampaignMedium();
         $this->name           = Piwik::translate('MarketingCampaignsReporting_Mediums');
+        $this->documentation  = '<b>' . Piwik::translate('MarketingCampaignsReporting_AttributionTitle') . ':</b> ' . Piwik::translate('MarketingCampaignsReporting_AttributionDocumentation', ['<a href="https://matomo.org/faq/general/faq_106/" rel="noreferrer noopener" target="_blank">', '</a>']);
         $this->hasGoalMetrics = true;
         $this->order          = 4;
 

Reports/GetName.php

@@ -20,6 +20,7 @@ protected function init()
     {
         parent::init();
         $this->dimension             = new CampaignName();
+        $this->documentation         = '<b>' . Piwik::translate('MarketingCampaignsReporting_AttributionTitle') . ':</b> ' . Piwik::translate('MarketingCampaignsReporting_AttributionDocumentation', ['<a href="https://matomo.org/faq/general/faq_106/" rel="noreferrer noopener" target="_blank">', '</a>']);
         $this->name                  = Piwik::translate('MarketingCampaignsReporting_Names');
         $this->actionToLoadSubTables = 'getKeywordContentFromNameId';
         $this->hasGoalMetrics        = true;

Reports/GetPlacement.php

@@ -19,6 +19,7 @@ protected function init()
         parent::init();
         $this->dimension      = new CampaignPlacement();
         $this->name           = Piwik::translate('MarketingCampaignsReporting_Placements');
+        $this->documentation  = '<b>' . Piwik::translate('MarketingCampaignsReporting_AttributionTitle') . ':</b> ' . Piwik::translate('MarketingCampaignsReporting_AttributionDocumentation', ['<a href="https://matomo.org/faq/general/faq_106/" rel="noreferrer noopener" target="_blank">', '</a>']);
         $this->hasGoalMetrics = true;
         $this->order          = 9;
 

Reports/GetSource.php

@@ -19,6 +19,7 @@ protected function init()
         parent::init();
         $this->dimension      = new CampaignSource();
         $this->name           = Piwik::translate('MarketingCampaignsReporting_Sources');
+        $this->documentation  = '<b>' . Piwik::translate('MarketingCampaignsReporting_AttributionTitle') . ':</b> ' . Piwik::translate('MarketingCampaignsReporting_AttributionDocumentation', ['<a href="https://matomo.org/faq/general/faq_106/" rel="noreferrer noopener" target="_blank">', '</a>']);
         $this->hasGoalMetrics = true;
         $this->order          = 3;
 

Reports/GetSourceMedium.php

@@ -20,6 +20,7 @@ protected function init()
         parent::init();
         $this->dimension             = new CampaignSourceMedium();
         $this->name                  = Piwik::translate('MarketingCampaignsReporting_CombinedSourcesMediums');
+        $this->documentation         = '<b>' . Piwik::translate('MarketingCampaignsReporting_AttributionTitle') . ':</b> ' . Piwik::translate('MarketingCampaignsReporting_AttributionDocumentation', ['<a href="https://matomo.org/faq/general/faq_106/" rel="noreferrer noopener" target="_blank">', '</a>']);
         $this->actionToLoadSubTables = 'getNameFromSourceMediumId';
         $this->hasGoalMetrics        = true;
         $this->order                 = 6;

lang/en.json

@@ -1,5 +1,7 @@
 {
     "MarketingCampaignsReporting": {
+        "AttributionTitle": "Attribution",
+        "AttributionDocumentation": "By default, conversion metrics in tables with Goal metrics are attributed to the last non-direct channel that brought visitors who converted. %1$sLearn more%2$s about conversion attribution.",
         "Name": "Campaign Name",
         "Keyword": "Campaign Keyword",
         "Source": "Campaign Source",

tests/UI/Reports_spec.js

@@ -18,6 +18,15 @@ describe("MarketingCampaignsReporting_Reports", function () {
         expect(await page.screenshotSelector('.pageWrap,.expandDataTableFooterDrawer')).to.matchImage('loaded');
     });
 
+    it('should show iconBar with info', async function () {
+        await page.evaluate(function() {
+            $('.card-title .iconsBar').show();
+            $('.card-title .iconsBar .helpIcon').click();
+            $('.card-title .helpDate').html('');
+        });
+        expect(await page.screenshot()).to.matchImage('icon_with_info');
+    });
+
     it('should show visits log with campaign details', async function() {
         await page.goto("?module=CoreHome&action=index&idSite=1&period=month&date=2013-01-23#?idSite=1&period=month&date=2013-01-23&category=General_Visitors&subcategory=Live_VisitorLog");
 
@@ -27,4 +36,4 @@ describe("MarketingCampaignsReporting_Reports", function () {
         var report = await page.$('.reporting-page');
         expect(await report.screenshot()).to.matchImage('visitor_log');
     });
-});
+});