FIX: improve redirect page #57
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Second commit skips top-level index.html (ahem I think) |
|
ping @QuLogic and @tacaswell I think this would make our redirect page that flashes up for a couple of second look not so bad.... |
QuLogic
reviewed
Apr 16, 2021
Comment on lines
+70
to
+71
| <!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN" | ||
| "http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd"> |
There was a problem hiding this comment.
Use html5 doctype, no need for xhtml at this point.
There was a problem hiding this comment.
thats just from the top of matplotlib.org?
<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN"
"http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd">
There was a problem hiding this comment.
Not in the current theme: https://github.com/matplotlib/mpl-brochure-site/blob/gh-pages/index.html
|
Did we not want to do this? |
|
@QuLogic Do we still use this script now that we have moved to selfhosting + caddy? |
|
For the time being yes, there are no redirects in Caddy at the moment. |
|
matplotlib/matplotlib.org#41 took care of this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds styling to the redirect page so when it flashes it at least doesn't look like an error..