feat: Simplify ram circuit input #48
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0xVolosnikov
force-pushed
the
vv-simplify-ram-circuit-input
branch
2 times, most recently
from
f341c38
to
2b0f039
Compare
0xVolosnikov
force-pushed
the
vv-simplify-ram-witgen-initial
branch
from
1a98048
to
3cc3e50
Compare
0xVolosnikov
force-pushed
the
vv-simplify-ram-circuit-input
branch
from
2b0f039
to
bca7156
Compare
|
In such case it's better to save even more RAM and change QueueRawWitness structure itself |
|
@shamatar I wasn't sure if it wasn't used in other circuits, so I tried to limit the changes to RAM only. I'll think about it. On the other hand, when processing one circuit in/before prover, the load on the RAM is small. Problems arise when there are several hundred of them (as in the witness generator) |
0xVolosnikov
force-pushed
the
vv-simplify-ram-circuit-input
branch
from
d0a1a38
to
c62d199
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.