Fix stream recreation crashes and thread starvation caused by MAVLink-related thread leak #330

joaoantoniocardoso · 2024-01-06T01:10:29Z

note: Merge after #303

This work:

Fix critical crashes when recreating streams
Fix MAVlink-related thread leak that leads to a crash or complete stall caused by thread starvation
Helps Error creating thread: Resource temporarily unavailable #310 because it fixes a thread leak related to the Mavlink and stream recreation
May helps To investigate - sequence of problems when recreating streams #308

…process

patrickelectric

Tested and working

joaoantoniocardoso added 27 commits January 5, 2024 22:06

src: stream: Post EOS from a new thread

205f1e5

src: stream: gst: Change to WeakRef<Element>

e54073d

src: stream: pipeline: Use WeakRef<Element>

89caadf

src: stream: gst: impl wait_for_element_state_async

5788e2a

src: stream: pipeline: Save dot file before removing the sink

fb5de01

src: stream: pipeline: clean format style

5655fa0

src: pipeline: Make PipelineRunner async

efef2f9

src: settings: Move to RWLock

2dc5757

src: stream: Move Stream to RWLock

ba40440

src: stream: Add debug for when a stream is started

a4b7a81

src: stream: Make add_stream_and_start and start_default async

3086b74

src: main, server: await for add_stream_and_start and start_default

562d272

src: stream: sink: Remove duplicated sync

eb59a5d

src: stream: sink: Fix typo

6783a8e

src: mavlink: Refactor MAVLink reconnection

322f558

src: mavlink: rename structs

61d1748

src: mavlink: Move MavlinkCamera to async

842d68d

src: mavlink: Implement Drop for MavinkCamera

3a7e253

src: stream: update MAVLink struct names

fdba2ef

src: stream: Move Manager to RWLock

ff0fdbb

src: mavlink: Move Stream and watcher to async

cbc7df7

src: mavlink: Reimplement Drop for Stream

7a5da8d

src: mavlink: Rewrite match into a block

70b327b

src: stream: Only acquire state Write lock when needed

5836632

src: stream: Finish MAVLink tasks before start the stream recreation …

87e80d0

…process

src: stream: Only create the MavlinkCamera when MAVLink is not disabled

74d5f62

src: Change main runtime to explicitly Tokio

eb5a916

joaoantoniocardoso requested a review from patrickelectric January 6, 2024 01:10

This was referenced Jan 6, 2024

mavlink,stream: Use a single thread worker #312

Closed

mavlink: mavlink_camera: Add shutdown mechanism #314

Closed

joaoantoniocardoso mentioned this pull request Jan 6, 2024

mavlink: mavlink_camera: Add debug message then removing mavlink camera handle #313

Closed

patrickelectric approved these changes Jan 8, 2024

View reviewed changes

patrickelectric merged commit 7614c36 into mavlink:master Jan 8, 2024
3 checks passed

joaoantoniocardoso deleted the fix/mavlink branch January 8, 2024 20:16

joaoantoniocardoso mentioned this pull request Jan 8, 2024

src: stream: Post EOS from a new thread #303

Closed

joaoantoniocardoso mentioned this pull request Apr 27, 2024

stream: Failed posting Eos message into Pipeline bus #309

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix stream recreation crashes and thread starvation caused by MAVLink-related thread leak #330

Fix stream recreation crashes and thread starvation caused by MAVLink-related thread leak #330

joaoantoniocardoso commented Jan 6, 2024

patrickelectric left a comment

Fix stream recreation crashes and thread starvation caused by MAVLink-related thread leak #330

Fix stream recreation crashes and thread starvation caused by MAVLink-related thread leak #330

Conversation

joaoantoniocardoso commented Jan 6, 2024

patrickelectric left a comment

Choose a reason for hiding this comment