Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix only provide parameters used by tool functions #200

Merged
merged 1 commit into from
Mar 21, 2024

Conversation

barnettwilliam
Copy link
Collaborator

Modified invokeActionFunction() to not populate unused parameters as 'undefined' because this is no longer necessary when using the Epsilon micronaut tool service.

Along epsilonlabs/playground-backend#4 with fixes #41

Mentioned in code review for PR #198 (comment)

…'undefined' because this is no longer necessary when using the Epsilon micronaut tool service.
Copy link
Contributor

@szschaler szschaler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM: do we need to wait for your PR in the Epsilon micronaut before merging this?

@barnettwilliam
Copy link
Collaborator Author

There's no need to wait for the Epsilon micronaut PR

@barnettwilliam barnettwilliam merged commit 3eefcaf into main Mar 21, 2024
7 checks passed
@barnettwilliam barnettwilliam deleted the fix/41-use-only-given-parameters branch March 21, 2024 09:14
barnettwilliam added a commit to mdenet/educationplatform-docker that referenced this pull request Mar 26, 2024
…refactor action function calling, mdenet/educationplatform#190 tests for ActivityValidator, mdenet/educationplatform#201 tests for EducationPlatformApp action function calling, mdenet/educationplatform#200 populate only required tool function parameters, mdenet/educationplatform#198 tests for EducationPlatformApp, and mdenet/platformtools#66 changed OCL tool language type to text.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Clean up Epsilon Wrapper so that functions only expect the parameters they are actually using
2 participants