Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Base URL Fix #213

Merged
merged 30 commits into from
Dec 12, 2024
Merged

Base URL Fix #213

merged 30 commits into from
Dec 12, 2024

Conversation

aryaei2000
Copy link
Collaborator

This is to remove the need of having to manually set base URLs on occasions where the platform needs to be accessed by an FQDN.

@aryaei2000 aryaei2000 added the enhancement New feature or request label Nov 21, 2024
@aryaei2000 aryaei2000 requested a review from szschaler November 21, 2024 13:25
@aryaei2000 aryaei2000 self-assigned this Nov 21, 2024
Copy link
Contributor

@szschaler szschaler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few comments to look at. Why does the discovery service need to run as a separate service in the first place?

discovery-service/Dockerfile Outdated Show resolved Hide resolved
discovery-service/package.json Outdated Show resolved Hide resolved
discovery-service/package.json Outdated Show resolved Hide resolved
platform/src/ToolsManager.js Outdated Show resolved Hide resolved
platform/src/ToolsManager.js Show resolved Hide resolved
platform/src/ToolsManager.js Show resolved Hide resolved
platform/src/ToolsManager.js Outdated Show resolved Hide resolved
@aryaei2000 aryaei2000 requested a review from szschaler December 9, 2024 20:21
@aryaei2000
Copy link
Collaborator Author

The only remaining issue is an unnecessary escape character in the lint report which I have no idea on why it's being caused. The forward slashes should be escaped and if the backslashes are removed the regular expression doesn't function as expected.
See here

Copy link
Contributor

@szschaler szschaler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few questions remain

platform/src/ToolsManager.js Outdated Show resolved Hide resolved
platform/src/ToolsManager.js Show resolved Hide resolved
platform/src/ToolsManager.js Outdated Show resolved Hide resolved
platform/src/ToolsManager.js Outdated Show resolved Hide resolved
platform/test/spec/testToolManagerSpec.js Outdated Show resolved Hide resolved
platform/test/spec/testToolManagerSpec.js Show resolved Hide resolved
@szschaler
Copy link
Contributor

The only remaining issue is an unnecessary escape character in the lint report which I have no idea on why it's being caused. The forward slashes should be escaped and if the backslashes are removed the regular expression doesn't function as expected. See here

The two that it flags are occurrences of \/ inside a character class (i.e., between [ and ]), where presumably the escaping isn't needed because the regexp parser can work out it's not the end of the regexp. I note that other occurrences of \/ in the same regexp are accepted by the linter.

@aryaei2000
Copy link
Collaborator Author

Linter is fixed thanks for the point!

@aryaei2000 aryaei2000 requested a review from szschaler December 12, 2024 15:16
Copy link
Contributor

@szschaler szschaler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aryaei2000 aryaei2000 merged commit de7c6ab into main Dec 12, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants