-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Base URL Fix #213
Base URL Fix #213
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few comments to look at. Why does the discovery service need to run as a separate service in the first place?
The only remaining issue is an unnecessary escape character in the lint report which I have no idea on why it's being caused. The forward slashes should be escaped and if the backslashes are removed the regular expression doesn't function as expected. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few questions remain
The two that it flags are occurrences of |
Co-authored-by: Steffen Zschaler <[email protected]>
Co-authored-by: Steffen Zschaler <[email protected]>
Linter is fixed thanks for the point! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This is to remove the need of having to manually set base URLs on occasions where the platform needs to be accessed by an FQDN.