Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Base URL Fix #213

Merged
merged 30 commits into from
Dec 12, 2024

Refactored isBaseUrlPlaceholder into two functions.

14fc855
Select commit
Loading
Failed to load commit list.
Sign in for the full log view
Merged

Base URL Fix #213

Refactored isBaseUrlPlaceholder into two functions.
14fc855
Select commit
Loading
Failed to load commit list.
GitHub Actions / Unit Test Results - mac succeeded Dec 12, 2024 in 0s

146 passed, 0 failed and 0 skipped

Tests passed successfully

✅ platform/reports/TESTS-Safari_18.1.1_(Mac_OS_10.15.7).xml

146 tests were completed in 1s with 146 passed, 0 failed and 0 skipped.

Test suite Passed Failed Skipped Time
Safari 18.1.1 (Mac OS 10.15.7) 146✅ 1s

✅ Safari 18.1.1 (Mac OS 10.15.7)

Safari_18_1_1_(Mac_OS_10_15_7).PlaygroundUtility notification()
  ✅ PlaygroundUtility notification() displays a message with given title and text
Safari_18_1_1_(Mac_OS_10_15_7).PlaygroundUtility longNotification()
  ✅ PlaygroundUtility longNotification() calls notification() with the given text
Safari_18_1_1_(Mac_OS_10_15_7).PlaygroundUtility successNotification()
  ✅ PlaygroundUtility successNotification() calls notification with the given text
Safari_18_1_1_(Mac_OS_10_15_7).PlaygroundUtility errorNotification()
  ✅ PlaygroundUtility errorNotification() calls notification with the given text
Safari_18_1_1_(Mac_OS_10_15_7).ActivityManager constructor
  ✅ ActivityManager constructor uses the query string to set the activitiesUrl property
  ✅ ActivityManager constructor initialises the fileHandler property  using param fileHandler
  ✅ ActivityManager constructor initialises the accessPanelDef property using param panelDefAccessor
  ✅ ActivityManager constructor initialises the configValidator property
  ✅ ActivityManager constructor can be created
  ✅ ActivityManager constructor sets the activityId property if the current activity is provided in the url query string
Safari_18_1_1_(Mac_OS_10_15_7).ActivityManager activity initialisation
  ✅ ActivityManager activity initialisation an activities property's value is an object
  ✅ ActivityManager activity initialisation the activities property is an object that has required keys
  ✅ ActivityManager activity initialisation no config errors empty configErrors property
  ✅ ActivityManager activity initialisation current activity activityId property is set to the activity id
  ✅ ActivityManager activity initialisation resolves references for a valid activity by  calling resolveActionReferences with activity id
  ✅ ActivityManager activity initialisation the activities actions property panel references have been resolved
  ✅ ActivityManager activity initialisation the panel definitions the current activity references are unresolved
  ✅ ActivityManager activity initialisation the activities property has a key matching the activity id
  ✅ ActivityManager activity initialisation causes the activity file to be fetched from its URL using the fileHandler
Safari_18_1_1_(Mac_OS_10_15_7).ActivityManager getting current activity
  ✅ ActivityManager getting current activity the panel definitions for the current activity references are resolved
  ✅ ActivityManager getting current activity the activity files are fetched using FileHandler
Safari_18_1_1_(Mac_OS_10_15_7).FunctionRegistry
  ✅ FunctionRegistry a single registered function using wildcards can be found
  ✅ FunctionRegistry a registered function using wildcards can be found
  ✅ FunctionRegistry can find a registered function
Safari_18_1_1_(Mac_OS_10_15_7).FunctionRegistry call()
  ✅ FunctionRegistry call() sends a request to the tool service url
  ✅ FunctionRegistry call() returns the result via promise
Safari_18_1_1_(Mac_OS_10_15_7).FunctionRegistry callConversion()
  ✅ FunctionRegistry callConversion() sends a request to the tool service url
  ✅ FunctionRegistry callConversion() returns the converted result via a promise
Safari_18_1_1_(Mac_OS_10_15_7).EducationPlatformApp runAction()
  ✅ EducationPlatformApp runAction() populates the language parameter
  ✅ EducationPlatformApp runAction() calls handleResponseActionFunction with the current action and the invoked function's result promise
  ✅ EducationPlatformApp runAction() calls invokeActionFunction with the action functions parameters and their values
  ✅ EducationPlatformApp runAction() provides a notification indicating functions are executing
  ✅ EducationPlatformApp runAction() raises an error when an action does not exist for a given panel using ErrorHandler notify
Safari_18_1_1_(Mac_OS_10_15_7).EducationPlatformApp handleResponseActionFunction()
  ✅ EducationPlatformApp handleResponseActionFunction() provides an error notification on unsuccessful function invocation result
Safari_18_1_1_(Mac_OS_10_15_7).Button
  ✅ Button createButtons - creates multiple buttons from  an array of button objects
  ✅ Button has an icon set by a config object
  ✅ Button has an id set by a config object
  ✅ Button can be created
  ✅ Button getView - outputs a DOM representation for customButtons properties
  ✅ Button has an hint set by a config object
Safari_18_1_1_(Mac_OS_10_15_7).ActivityConfigValidator validate activity configuration
  ✅ ActivityConfigValidator validate activity configuration returns an error if a panel button in config has no icon key
  ✅ ActivityConfigValidator validate activity configuration returns an error if the config has no actions key
  ✅ ActivityConfigValidator validate activity configuration returns an error if the config has no id key
  ✅ ActivityConfigValidator validate activity configuration returns an error if a panel in config has no ref key
  ✅ ActivityConfigValidator validate activity configuration returns an error if the config has no layout key
  ✅ ActivityConfigValidator validate activity configuration reports no errors for a valid config
  ✅ ActivityConfigValidator validate activity configuration returns an error if a panel button in config has no id key
  ✅ ActivityConfigValidator validate activity configuration returns an error if the config has no tools key
  ✅ ActivityConfigValidator validate activity configuration returns an error if the config has no title key
  ✅ ActivityConfigValidator validate activity configuration returns an error if the config layout has no area key
  ✅ ActivityConfigValidator validate activity configuration returns an error if a config action has no source key
  ✅ ActivityConfigValidator validate activity configuration returns an error if a config action has no parameters key
  ✅ ActivityConfigValidator validate activity configuration returns an error if the config has no panels key
  ✅ ActivityConfigValidator validate activity configuration returns an error if a panel button ref in config has no ref key
  ✅ ActivityConfigValidator validate activity configuration returns an error if a panel in config has no id key
  ✅ ActivityConfigValidator validate activity configuration returns an error if a panel in config has no name key
  ✅ ActivityConfigValidator validate activity configuration returns an error if a config action has no sourceButton key
  ✅ ActivityConfigValidator validate activity configuration returns an error if a config action has no output key
Safari_18_1_1_(Mac_OS_10_15_7).ActivityConfigValidator constructor
  ✅ ActivityConfigValidator constructor can be created
Safari_18_1_1_(Mac_OS_10_15_7).ToolConfigValidator constructor
  ✅ ToolConfigValidator constructor can be created
Safari_18_1_1_(Mac_OS_10_15_7).ToolConfigValidator validate tool configuration
  ✅ ToolConfigValidator validate tool configuration returns an error if a parameter in the config has no name key
  ✅ ToolConfigValidator validate tool configuration returns an error if a parameter in the config has no type key
  ✅ ToolConfigValidator validate tool configuration returns an error if a function in the config has no returnType key
  ✅ ToolConfigValidator validate tool configuration returns an error if a function in the config has no path key
  ✅ ToolConfigValidator validate tool configuration returns an error if a function in the config has no parameters key
  ✅ ToolConfigValidator validate tool configuration returns an error if a panel definition in the config has no name key
  ✅ ToolConfigValidator validate tool configuration returns an error if a panel definition in the config has no panelclass key
  ✅ ToolConfigValidator validate tool configuration returns an error if a panel definition in the config has no icon key
  ✅ ToolConfigValidator validate tool configuration returns an error if the config has no id key
  ✅ ToolConfigValidator validate tool configuration returns an error if a function in the config has no name key
  ✅ ToolConfigValidator validate tool configuration returns an error if the config has no name key
  ✅ ToolConfigValidator validate tool configuration returns an error if the config has no functions key
  ✅ ToolConfigValidator validate tool configuration returns an error if a panel definition in the config has no id key
  ✅ ToolConfigValidator validate tool configuration returns an error if a button in the config has no id key
  ✅ ToolConfigValidator validate tool configuration returns an error if a button in the config has no id key
  ✅ ToolConfigValidator validate tool configuration reports no errors for a valid config
  ✅ ToolConfigValidator validate tool configuration returns an error if a function in the config has no id key
Safari_18_1_1_(Mac_OS_10_15_7).FileHandler
  ✅ FileHandler getPrivateFileUpdateParams - returns null for an unknown file url
  ✅ FileHandler getPrivateFileRequestUrl - returns null for an unknown file url
  ✅ FileHandler getPrivateFileRequestUrl - returns a token server request url from a raw github file url
  ✅ FileHandler githubRawUrlTorequestUrl - returns a token server request url from a raw github file url
  ✅ FileHandler getPrivateFileUpdateParams - returns
  ✅ FileHandler githubRawUrlToStoreRequest - returns an object with a token server requestParams member from a raw github file url
  ✅ FileHandler githubRawUrlToStoreRequest - returns an object with a token server request url member from a raw github file url
Safari_18_1_1_(Mac_OS_10_15_7).ErrorHandler constructor()
  ✅ ErrorHandler constructor() initialises window.onError with function that calls notify
Safari_18_1_1_(Mac_OS_10_15_7).ErrorHandler notify()
  ✅ ErrorHandler notify() calls errorNotification() with error information
Safari_18_1_1_(Mac_OS_10_15_7).Utility
  ✅ Utility parseConfigFile - an invald json file returns an error
  ✅ Utility parseConfigFile - an invald yaml file returns an error
  ✅ Utility arrayEquals - arrays with the same values in differing order are not the same
  ✅ Utility arrayEquals - arrays with matching values are the same
  ✅ Utility arrayEquals - when allow any is not enabled, arrays with any wildcard do not match the corresponding element
  ✅ Utility arrayEquals - arrays with an any wildcard always match the corresponding element
  ✅ Utility arrayEquals - arrays with a wildcard and non matchng other element are not the same
  ✅ Utility parseConfigFile - a json file parsed as yaml to an object
  ✅ Utility parseConfigFile - an unknown file type returns null
  ✅ Utility parseConfigFile - a yaml file is parsed to an object
  ✅ Utility parseConfigFile - a json file is parsed to an object
Safari_18_1_1_(Mac_OS_10_15_7).ActionFunction getInstanceOfParamName()
  ✅ ActionFunction getInstanceOfParamName() returns null if the given parameter is not an instance of a metamodel
  ✅ ActionFunction getInstanceOfParamName() returns the instanceOf parameter name for the given parameter if it is an instance of a metamodel
Safari_18_1_1_(Mac_OS_10_15_7).ActionFunction constructor()
  ✅ ActionFunction constructor() sets the created ActionFunction's id from a given config object
Safari_18_1_1_(Mac_OS_10_15_7).ActivityValidator checkActions()
  ✅ ActivityValidator checkActions() returns an error if output panel ids cannot be resolved
  ✅ ActivityValidator checkActions() returns an error if outputConsole panel ids cannot be resolved
  ✅ ActivityValidator checkActions() returns no errors if panel ids can be resolved
  ✅ ActivityValidator checkActions() returns an error if source panel ids cannot be resolved
Safari_18_1_1_(Mac_OS_10_15_7).ActivityValidator checkLayoutPanelIdsExist()
  ✅ ActivityValidator checkLayoutPanelIdsExist() returns no errors if panel ids can be resolved
  ✅ ActivityValidator checkLayoutPanelIdsExist() returns an error if a panel ids cannot be resolved
Safari_18_1_1_(Mac_OS_10_15_7).ActivityValidator idExists()
  ✅ ActivityValidator idExists() returns true if an id that exists in the items is found where the items are classes
  ✅ ActivityValidator idExists() returns false if an id does not exist in the items
  ✅ ActivityValidator idExists() returns true if an id that exists in the items is found
Safari_18_1_1_(Mac_OS_10_15_7).ActivityValidator validate()
  ✅ ActivityValidator validate() calls all validation functions
  ✅ ActivityValidator validate() returns errors if invalid activity and tools are given
  ✅ ActivityValidator validate() returns no errors if valid activity and tools are given
Safari_18_1_1_(Mac_OS_10_15_7).ActivityValidator checkPanelDefs()
  ✅ ActivityValidator checkPanelDefs() returns an error if a panel definition button renderfunction ref cannot be resolved
  ✅ ActivityValidator checkPanelDefs() returns an error if a panel definition button actionfunction ref cannot be resolved
  ✅ ActivityValidator checkPanelDefs() returns no errors if panel definitions are valid
Safari_18_1_1_(Mac_OS_10_15_7).ActivityValidator checkPanelRefs()
  ✅ ActivityValidator checkPanelRefs() returns an error if a panel definition ref is not resolved
  ✅ ActivityValidator checkPanelRefs() returns no errors if panel definition refs are resolved
Safari_18_1_1_(Mac_OS_10_15_7).ToolManager tool grammar imports
  ✅ ToolManager tool grammar imports correctly loads the URL of the ace grammar for a defined tool
  ✅ ToolManager tool grammar imports correctly loads the ace grammar module for a defined tool
Safari_18_1_1_(Mac_OS_10_15_7).ToolManager constructor
  ✅ ToolManager constructor can be created
Safari_18_1_1_(Mac_OS_10_15_7).ToolManager selectConversionFunctionConvertMetamodel()
  ✅ ToolManager selectConversionFunctionConvertMetamodel() returns a function id, converts the metamodel, and adds the converted metamodel value to the typeValueMap if a conversion is possible considering the metamodel
  ✅ ToolManager selectConversionFunctionConvertMetamodel() returns null if no conversion is available considering the metamodel
  ✅ ToolManager selectConversionFunctionConvertMetamodel() returns null if a conversion is not possible without considering the metamodel
  ✅ ToolManager selectConversionFunctionConvertMetamodel() returns a function id if a conversion is possible without considering the metamodel
Safari_18_1_1_(Mac_OS_10_15_7).ToolManager initialisation
  ✅ ToolManager initialisation isIDPlaceHolder - check if a string is an ID placeholder
  ✅ ToolManager initialisation parses and stores the tool configuration
  ✅ ToolManager initialisation rewrites tool urls
  ✅ ToolManager initialisation fetchPathByPort - fetch paths by a port number
  ✅ ToolManager initialisation isValidUrl - test validity of urls
  ✅ ToolManager initialisation fetches the tool configuration from the remote given by its URL
  ✅ ToolManager initialisation sets tools URLs correctly
  ✅ ToolManager initialisation getPort - detects and returns port in a URL placeholder and port combination
  ✅ ToolManager initialisation isBaseUrlPlaceHolder - check if a string is a url placeholder
Safari_18_1_1_(Mac_OS_10_15_7).ToolManager panel definitions
  ✅ ToolManager panel definitions returns the correct object for an existing panel definition id
  ✅ ToolManager panel definitions returns null for a panel definition id that does not exist
Safari_18_1_1_(Mac_OS_10_15_7).ToolManager convertIncludingMetamodel()
  ✅ ToolManager convertIncludingMetamodel() returns null and provides an error notification on a conversion function not being available
  ✅ ToolManager convertIncludingMetamodel() returns a promise on a conversion function being available
  ✅ ToolManager convertIncludingMetamodel() calls functionRegister.callConversion() on a conversion function being available
Safari_18_1_1_(Mac_OS_10_15_7).ToolManager invokeActionFunction()
  ✅ ToolManager invokeActionFunction() returns the result via a promise
  ✅ ToolManager invokeActionFunction() sends requests to a conversion function's url without unused parameters
  ✅ ToolManager invokeActionFunction() calls functionRegister.call() with the converted parameter values for non-matching types including a metamodel
  ✅ ToolManager invokeActionFunction() calls functionRegister.call() with the converted parameter values for non-matching types
  ✅ ToolManager invokeActionFunction() calls functionRegister.call() with the given parameter values for matching types
Safari_18_1_1_(Mac_OS_10_15_7).ToolManager convert()
  ✅ ToolManager convert() calls functionRegistry_callConversion on a conversion function being available
  ✅ ToolManager convert() returns a promise on a conversion function being available
  ✅ ToolManager convert() returns null and provides an error notification on a conversion function not being available