-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move getSelection to Document and ShadowRoot; Mark ShadowRoot.getSelection as non-standard. #9431
Conversation
Chromium does have ShadowRoot#getSelection because it's in the Also confirmed with https://mdn-bcd-collector.appspot.com/tests/api/ShadowRoot/getSelection However, that entry isn't on the same footing as the one on |
w3c/selection-api#114 is the spec issue for this situation. |
Prompted by mdn#9431 and confirmed by mdn-bcd-collector results.
I've sent #9434. With that merged it should be a simple matter of moving the entries around. |
Thanks @foolip! Now this PR looks a bit more silly than before, but I guess it is still correct given the chromium implementation could remain non-standard. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't the other one also be moved and have its mdn_url
either updated or removed?
Moved It and removed the mdn_url. We will see long-term if all this moving around makes sense. It doesn't change what BCD exposes after all. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll leave merging to you, since the description needs updating.
Fixes #7891
Spec: https://w3c.github.io/selection-api/#extensions-to-document-interface
Delete getSelection from DocumentOrShadowRoot files and add it to Document. On Window, it already exists.
MDN content PR: mdn/content#3037