Mention the safe range of 'time' param value of timeout() #36054
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BartoszKlonowski
requested review from
sideshowbarker
and removed request for
a team
github-actions
bot
added
Content:WebAPI
|
Preview URLs (comment last updated: 2024-09-26 22:12:40) |
github-actions
bot
added
size/s
Josh-Cena
reviewed
Sep 26, 2024
| @@ -27,6 +27,7 @@ AbortSignal.timeout(time) | |||
|
|
|||
| - `time` | |||
| - : The "active" time in milliseconds before the returned {{domxref("AbortSignal")}} will abort. | |||
| The value must be within range of 0 and {{jsxref("Number.MAX_SAFE_INTEGER")}} | |||
There was a problem hiding this comment.
Suggested change
| The value must be within range of 0 and {{jsxref("Number.MAX_SAFE_INTEGER")}} | |
| The value must be within range of 0 and {{jsxref("Number.MAX_SAFE_INTEGER")}}. |
| @@ -69,3 +70,7 @@ try { | |||
| ## Browser compatibility | |||
|
|
|||
| {{Compat}} | |||
|
|
|||
| ## See also | |||
There was a problem hiding this comment.
Remove this; it's a really minor point and not directly related. If you really want to add a see also, link to setTimeout instead.
github-actions
bot
added
size/xs
OnkarRuikar
pushed a commit
to OnkarRuikar/content
that referenced
this pull request
Sep 28, 2024
* Mention the safe range of 'time' param value of timeout() * Add 'isSafeInteger' to the See also section * Correct the link for case sensitivity * Revert "Correct the link for case sensitivity" This reverts commit 8760abd. * Revert "Add 'isSafeInteger' to the See also section" This reverts commit 9d72aa5. * Add missing dot for the range addition
fiji-flo
pushed a commit
that referenced
this pull request
Oct 2, 2024
* Mention the safe range of 'time' param value of timeout() * Add 'isSafeInteger' to the See also section * Correct the link for case sensitivity * Revert "Correct the link for case sensitivity" This reverts commit 8760abd. * Revert "Add 'isSafeInteger' to the See also section" This reverts commit 9d72aa5. * Add missing dot for the range addition
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request fixes #36044
It adds the brief note of a range of value that can be passed to
timeout()method.Because the
timeshould be of typeunsigned long, I described it as the range of 0Number.MAX_SAFE_INTEGER.