-
Notifications
You must be signed in to change notification settings - Fork 22.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mention the safe range of 'time' param value of timeout() #36054
Merged
Josh-Cena
merged 6 commits into
mdn:main
from
BartoszKlonowski:fix/36044/abort-controller-timeout
Sep 26, 2024
Merged
Changes from 3 commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
a074daf
Mention the safe range of 'time' param value of timeout()
BartoszKlonowski 9d72aa5
Add 'isSafeInteger' to the See also section
BartoszKlonowski 8760abd
Correct the link for case sensitivity
BartoszKlonowski a9e3ca5
Revert "Correct the link for case sensitivity"
BartoszKlonowski 453b76d
Revert "Add 'isSafeInteger' to the See also section"
BartoszKlonowski dd462d1
Add missing dot for the range addition
BartoszKlonowski File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -27,6 +27,7 @@ AbortSignal.timeout(time) | |
|
||
- `time` | ||
- : The "active" time in milliseconds before the returned {{domxref("AbortSignal")}} will abort. | ||
The value must be within range of 0 and {{jsxref("Number.MAX_SAFE_INTEGER")}} | ||
|
||
### Return value | ||
|
||
|
@@ -69,3 +70,7 @@ try { | |
## Browser compatibility | ||
|
||
{{Compat}} | ||
|
||
## See also | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Remove this; it's a really minor point and not directly related. If you really want to add a see also, link to |
||
|
||
- [`Number.isSafeInteger()`](/en-US/docs/Web/JavaScript/Reference/Global_Objects/Number/isSafeInteger) |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.