-
Notifications
You must be signed in to change notification settings - Fork 512
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(spas): streamline 404 #12248
feat(spas): streamline 404 #12248
Conversation
This has been a special case, let's streamline it a bit.
Bundle StatsHey there, this message comes from a github action that helps you and reviewers to understand how these changes affect the size of this project's bundle. As this PR is updated, I'll keep you updated on how the bundle size is impacted. Total
View detailed bundle breakdownAdded No assets were added Removed No assets were removed Bigger No assets were bigger Smaller No assets were smaller Unchanged
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but my only concern is that during deployment, the 404 page will be broken temporarily between the removal of the _spas/404.html
during sync and the deployment of the new Cloud Function.
Noted, I think that's okay. |
Summary
The 404 "SPA" is the only page in _spas and behaves very different than the rest. Let's streamline this.
How did you test this change?
Deployed to test.
https://test.developer.allizom.org/en-US/docs/Web/CSS/foo