fix: ensure 0 deltaFlow doesn't update state #550
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RyRy79261
approved these changes
Nov 22, 2024
baroooo
requested changes
Nov 25, 2024
baroooo
approved these changes
Nov 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This Pr fixes in issue in the way our trading limits handle subunit amounts. Before when :
deltaFlowUnits == 0deltaFlowUnitswas set to either 1 or -1 without checking whether the deltaFlow is 0.This resulted in a swap with 0 amounts updating the trading limit state by -1.
Other changes
Tested
Related issues
Backwards compatibility
Documentation