Refactor limit handling #273
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Section 7.3.6.5 of the ASAM ODX specification defines how strings, bytearrays and numeric objects ought to be compared, and the proceedure for bytearrays is not completely intuitive. This has some consequences for testing the applicability of limits. Signed-off-by: Andreas Lauser <[email protected]> Signed-off-by: Michael Hahn <[email protected]>
also, use it at the places where compu scales are tested. Signed-off-by: Andreas Lauser <[email protected]> Signed-off-by: Michael Hahn <[email protected]>
this is surprisingly difficult: the problem is that the LIMIT tag does not specify the data type (integer, float, string, bytefield) which the limit is about but the limit obviously needs to know that type in order to do something. The solution taken here is to pass the type of the limit's value to the `from_et()` method as an extra argument. For Multiplexer cases where even the type of the limit's value is not known when the limit must be created, (this is only known after the switch key reference has been resolved) the method `Limit.set_value_type()` is added. Signed-off-by: Andreas Lauser <[email protected]> Signed-off-by: Michael Hahn <[email protected]>
andlaus
force-pushed
the
refactor_limits
branch
from
9d2fab1
to
893a02a
Compare
i.e., 0.2.2 . this one started complaining about renamed configuration options. Signed-off-by: Andreas Lauser <[email protected]> Signed-off-by: Michael Hahn <[email protected]>
andlaus
force-pushed
the
refactor_limits
branch
from
893a02a
to
6f1e172
Compare
kayoub5
reviewed
Mar 1, 2024
|
Does the limit really need to know its data type during creation? The datatype can be simply passed as argument to |
not during creation, but as soon as it must check if a value adheres to the specified limit.
I considered doing that. It turns out that this implies that the limit value must be converted from string each and every time which a limit is checked (and the code felt quite clunky and "footgunny" because one can easily pass the wrong type to these methods...) |
thanks to [at]kayoub5 for the finds. Signed-off-by: Andreas Lauser <[email protected]> Signed-off-by: Michael Hahn <[email protected]>
|
@kayoub5: Do you think that this can be merged? |
kayoub5
approved these changes
Mar 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
today, we set out to clean up the limit handling code. this is surprisingly difficult: the problem is that the LIMIT tag does not specify the data type (integer, float, string, bytefield) which the limit is about but the limit obviously needs to know that type in order to do something. The solution taken here is to pass the type of the limit's value to the
from_et()method as an extra argument. For multiplexer cases where even the type of the limit's value is not known when the limit must be instantiated, (this is only known after the reference to the switch key has been resolved) the methodLimit.set_value_type()is added.Andreas Lauser <[email protected]>, on behalf of MBition GmbH.
Provider Information