Avoid incompatible overrides #276
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Andreas Lauser <[email protected]> Signed-off-by: Gerrit Ecke <[email protected]>
andlaus
force-pushed
the
no_incompatible_overrides
branch
from
c88a29a
to
7e40375
Compare
if the class containing such a method is derived from another class (like e.g. `NamedElement`), some linters complain that the derived class overrides the method in an incompatible way. (IMO these complaints are justified.) Signed-off-by: Andreas Lauser <[email protected]> Signed-off-by: Gerrit Ecke <[email protected]>
andlaus
force-pushed
the
no_incompatible_overrides
branch
from
7e40375
to
097afaf
Compare
kayoub5
approved these changes
Mar 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the incompatible overrides of
from_et()methods which require additional arguments by renaming them to.{foo}_from_et()(e.g.Limit.limit_from_et()). Some type checkers complain about this, IMO rightfully so.Besides this, as a drive-by I've updated the
READMEso that the snippets outlined there work with the latest odxtools version. (I don't think that this changelet merrits its own PR.)Andreas Lauser <[email protected]>, on behalf of MBition GmbH.
Provider Information