Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid incompatible overrides #276

Merged
merged 2 commits into from
Mar 4, 2024
Merged

Avoid incompatible overrides #276

merged 2 commits into from
Mar 4, 2024

Commits on Mar 4, 2024

  1. bring the snippets showcased in the README file up to snuff 

    Signed-off-by: Andreas Lauser <[email protected]>
Signed-off-by: Gerrit Ecke <[email protected]>
    @andlaus
    andlaus committed Mar 4, 2024
    Configuration menu
    Copy the full SHA
    459767d View commit details
    Browse the repository at this point in the history

  2. rename all .from_et() methods that take additional arguments 

    if the class containing such a method is derived from another class
(like e.g. `NamedElement`), some linters complain that the derived
class overrides the method in an incompatible way. (IMO these
complaints are justified.)

Signed-off-by: Andreas Lauser <[email protected]>
Signed-off-by: Gerrit Ecke <[email protected]>
    @andlaus
    andlaus committed Mar 4, 2024
    Configuration menu
    Copy the full SHA
    097afaf View commit details
    Browse the repository at this point in the history