forked from bloom-housing/bloom
-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: remove contact preferences #956
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ColinBuyck
commented
Nov 25, 2024
ColinBuyck
commented
Nov 25, 2024
ColinBuyck
force-pushed
the
935/application-questions
branch
from
November 25, 2024 22:06
702ecce
to
87583c9
Compare
ludtkemorgan
approved these changes
Dec 2, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just the one test cleanup
ludtkemorgan
added
ready to merge
Should be applied when a PR has been reviewed and approved
and removed
1 review needed
labels
Dec 2, 2024
ColinBuyck
force-pushed
the
935/application-questions
branch
from
December 3, 2024 14:16
87583c9
to
b821d53
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses #935
Description
This PR updates the application flow in Doorway to no longer include the how would you like to be contacted question and update the household member relation options. Additionally, it removes the work address fields from the application export since it was missed on the last removal.
How Can This Be Tested/Reviewed?
This can be tested by going through the online application in different languages/paper application on the partners portal and seeing the changes described above. Additionally, check the applications export and verify that there aren't any references to contact preferences or work addresses.
Author Checklist:
yarn generate:client
and/or created a migration when requiredReview Process: