Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove contact preferences #956

Merged
merged 15 commits into from
Dec 3, 2024
Merged

fix: remove contact preferences #956

merged 15 commits into from
Dec 3, 2024

Conversation

ColinBuyck
Copy link
Collaborator

@ColinBuyck ColinBuyck commented Nov 19, 2024

This PR addresses #935

  • Addresses the issue in full
  • Addresses only certain aspects of the issue

Description

This PR updates the application flow in Doorway to no longer include the how would you like to be contacted question and update the household member relation options. Additionally, it removes the work address fields from the application export since it was missed on the last removal.

How Can This Be Tested/Reviewed?

This can be tested by going through the online application in different languages/paper application on the partners portal and seeing the changes described above. Additionally, check the applications export and verify that there aren't any references to contact preferences or work addresses.

Author Checklist:

  • Added QA notes to the issue with applicable URLs
  • Reviewed in a desktop view
  • Reviewed in a mobile view
  • Reviewed considering accessibility
  • Added tests covering the changes
  • Made corresponding changes to the documentation
  • Ran yarn generate:client and/or created a migration when required

Review Process:

  • Read and understand the issue
  • Ensure the author has added QA notes
  • Review the code itself from a style point of view
  • Pull the changes down locally and test that the acceptance criteria is met
  • Either (1) explicitly ask a clarifying question, (2) request changes, or (3) approve the PR, even if there are very small remaining changes, if you don't need to re-review after the updates

@ColinBuyck ColinBuyck marked this pull request as ready for review November 25, 2024 22:05
@ColinBuyck ColinBuyck force-pushed the 935/application-questions branch from 702ecce to 87583c9 Compare November 25, 2024 22:06
Copy link
Collaborator

@ludtkemorgan ludtkemorgan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just the one test cleanup

@ludtkemorgan ludtkemorgan added ready to merge Should be applied when a PR has been reviewed and approved and removed 1 review needed labels Dec 2, 2024
@ColinBuyck ColinBuyck force-pushed the 935/application-questions branch from 87583c9 to b821d53 Compare December 3, 2024 14:16
@ColinBuyck ColinBuyck merged commit a323c84 into main Dec 3, 2024
16 checks passed
@ColinBuyck ColinBuyck deleted the 935/application-questions branch December 3, 2024 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge Should be applied when a PR has been reviewed and approved
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants