Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove contact preferences #956

Merged
merged 15 commits into from
Dec 3, 2024
21 changes: 9 additions & 12 deletions api/src/enums/applications/household-member-relationship-enum.ts
Original file line number Diff line number Diff line change
@@ -1,17 +1,14 @@
export enum HouseholdMemberRelationship {
spouse = 'spouse',
registeredDomesticPartner = 'registeredDomesticPartner',
parent = 'parent',
spousePartner = 'spousePartner',
girlfriendBoyfriend = 'girlfriendBoyfriend',
child = 'child',
sibling = 'sibling',
cousin = 'cousin',
aunt = 'aunt',
uncle = 'uncle',
nephew = 'nephew',
niece = 'niece',
grandparent = 'grandparent',
greatGrandparent = 'greatGrandparent',
inLaw = 'inLaw',
parent = 'parent',
friend = 'friend',
brotherSister = 'brotherSister',
cousin = 'cousin',
auntUncle = 'auntUncle',
nephewNiece = 'nephewNiece',
grandparentGreatGrandparent = 'grandparentGreatGrandparent',
liveInAide = 'liveInAide',
other = 'other',
}
28 changes: 0 additions & 28 deletions api/src/utilities/application-export-helpers.ts
Original file line number Diff line number Diff line change
Expand Up @@ -116,10 +116,6 @@ export const getExportHeaders = (
path: 'additionalPhoneNumber',
label: 'Primary Applicant Additional Phone Number',
},
{
path: 'contactPreferences',
label: 'Primary Applicant Preferred Contact Type',
},
{
path: 'applicant.applicantAddress.street',
label: `Primary Applicant Street`,
Expand Down Expand Up @@ -160,26 +156,6 @@ export const getExportHeaders = (
path: 'applicationsMailingAddress.zipCode',
label: `Primary Applicant Mailing Zip Code`,
},
{
path: 'applicant.applicantWorkAddress.street',
label: `Primary Applicant Work Street`,
},
{
path: 'applicant.applicantWorkAddress.street2',
label: `Primary Applicant Work Street 2`,
},
{
path: 'applicant.applicantWorkAddress.city',
label: `Primary Applicant Work City`,
},
{
path: 'applicant.applicantWorkAddress.state',
label: `Primary Applicant Work State`,
},
{
path: 'applicant.applicantWorkAddress.zipCode',
label: `Primary Applicant Work Zip Code`,
},
{
path: 'alternateContact.firstName',
label: 'Alternate Contact First Name',
Expand Down Expand Up @@ -534,10 +510,6 @@ export const getHouseholdCsvHeaders = (
path: `householdMember.${i}.relationship`,
label: `Household Member (${j}) Relationship`,
},
{
path: `householdMember.${i}.workInRegion`,
label: `Household Member (${j}) Work in Region`,
},
{
path: `householdMember.${i}.householdMemberAddress.street`,
label: `Household Member (${j}) Street`,
Expand Down
8 changes: 4 additions & 4 deletions api/test/unit/services/application-exporter.service.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -105,9 +105,9 @@ describe('Testing application export service', () => {
);

const headerRow =
'"Application Id","Application Confirmation Code","Application Type","Application Submission Date","Application Received At","Application Received By","Primary Applicant First Name","Primary Applicant Middle Name","Primary Applicant Last Name","Primary Applicant Birth Day","Primary Applicant Birth Month","Primary Applicant Birth Year","Primary Applicant Email Address","Primary Applicant Phone Number","Primary Applicant Phone Type","Primary Applicant Additional Phone Number","Primary Applicant Preferred Contact Type","Primary Applicant Street","Primary Applicant Street 2","Primary Applicant City","Primary Applicant State","Primary Applicant Zip Code","Primary Applicant Mailing Street","Primary Applicant Mailing Street 2","Primary Applicant Mailing City","Primary Applicant Mailing State","Primary Applicant Mailing Zip Code","Primary Applicant Work Street","Primary Applicant Work Street 2","Primary Applicant Work City","Primary Applicant Work State","Primary Applicant Work Zip Code","Alternate Contact First Name","Alternate Contact Last Name","Alternate Contact Type","Alternate Contact Agency","Alternate Contact Other Type","Alternate Contact Email Address","Alternate Contact Phone Number","Alternate Contact Street","Alternate Contact Street 2","Alternate Contact City","Alternate Contact State","Alternate Contact Zip Code","Income","Income Period","Accessibility Mobility","Accessibility Vision","Accessibility Hearing","Expecting Household Changes","Household Includes Student or Member Nearing 18","Vouchers or Subsidies","Requested Unit Types","Preference text 0","Preference text 0 - text - Address","Program text 1","Household Size","Household Member (1) First Name","Household Member (1) Middle Name","Household Member (1) Last Name","Household Member (1) First Name","Household Member (1) Birth Day","Household Member (1) Birth Month","Household Member (1) Birth Year","Household Member (1) Same as Primary Applicant","Household Member (1) Relationship","Household Member (1) Work in Region","Household Member (1) Street","Household Member (1) Street 2","Household Member (1) City","Household Member (1) State","Household Member (1) Zip Code","Marked As Duplicate","Flagged As Duplicate"';
'"Application Id","Application Confirmation Code","Application Type","Application Submission Date","Application Received At","Application Received By","Primary Applicant First Name","Primary Applicant Middle Name","Primary Applicant Last Name","Primary Applicant Birth Day","Primary Applicant Birth Month","Primary Applicant Birth Year","Primary Applicant Email Address","Primary Applicant Phone Number","Primary Applicant Phone Type","Primary Applicant Additional Phone Number","Primary Applicant Street","Primary Applicant Street 2","Primary Applicant City","Primary Applicant State","Primary Applicant Zip Code","Primary Applicant Mailing Street","Primary Applicant Mailing Street 2","Primary Applicant Mailing City","Primary Applicant Mailing State","Primary Applicant Mailing Zip Code","Alternate Contact First Name","Alternate Contact Last Name","Alternate Contact Type","Alternate Contact Agency","Alternate Contact Other Type","Alternate Contact Email Address","Alternate Contact Phone Number","Alternate Contact Street","Alternate Contact Street 2","Alternate Contact City","Alternate Contact State","Alternate Contact Zip Code","Income","Income Period","Accessibility Mobility","Accessibility Vision","Accessibility Hearing","Expecting Household Changes","Household Includes Student or Member Nearing 18","Vouchers or Subsidies","Requested Unit Types","Preference text 0","Preference text 0 - text - Address","Program text 1","Household Size","Household Member (1) First Name","Household Member (1) Middle Name","Household Member (1) Last Name","Household Member (1) First Name","Household Member (1) Birth Day","Household Member (1) Birth Month","Household Member (1) Birth Year","Household Member (1) Same as Primary Applicant","Household Member (1) Relationship","Household Member (1) Street","Household Member (1) Street 2","Household Member (1) City","Household Member (1) State","Household Member (1) Zip Code","Marked As Duplicate","Flagged As Duplicate"';
const firstApp =
'"application 0 firstName","application 0 middleName","application 0 lastName","application 0 birthDay","application 0 birthMonth","application 0 birthYear","application 0 emailaddress","application 0 phoneNumber","application 0 phoneNumberType","additionalPhoneNumber 0",,"application 0 applicantAddress street","application 0 applicantAddress street2","application 0 applicantAddress city","application 0 applicantAddress state","application 0 applicantAddress zipCode",,,,,,"application 0 applicantWorkAddress street","application 0 applicantWorkAddress street2","application 0 applicantWorkAddress city","application 0 applicantWorkAddress state","application 0 applicantWorkAddress zipCode",,,,,,,,,,,,,"income 0","per month",,,,"true","true","true","Studio,One Bedroom",,,,,,,,,,,,,,,,,,,,';
'"application 0 firstName","application 0 middleName","application 0 lastName","application 0 birthDay","application 0 birthMonth","application 0 birthYear","application 0 emailaddress","application 0 phoneNumber","application 0 phoneNumberType","additionalPhoneNumber 0","application 0 applicantAddress street","application 0 applicantAddress street2","application 0 applicantAddress city","application 0 applicantAddress state","application 0 applicantAddress zipCode",,,,,,,,,,,,,,,,,,"income 0","per month",,,,"true","true","true","Studio,One Bedroom",,,,,,,,,,,,,,,,,,,';

const mockedStream = new PassThrough();
exportResponse.getStream().pipe(mockedStream);
Expand Down Expand Up @@ -164,9 +164,9 @@ describe('Testing application export service', () => {
);

const headerRow =
'"Application Id","Application Confirmation Code","Application Type","Application Submission Date","Application Received At","Application Received By","Primary Applicant First Name","Primary Applicant Middle Name","Primary Applicant Last Name","Primary Applicant Birth Day","Primary Applicant Birth Month","Primary Applicant Birth Year","Primary Applicant Email Address","Primary Applicant Phone Number","Primary Applicant Phone Type","Primary Applicant Additional Phone Number","Primary Applicant Preferred Contact Type","Primary Applicant Street","Primary Applicant Street 2","Primary Applicant City","Primary Applicant State","Primary Applicant Zip Code","Primary Applicant Mailing Street","Primary Applicant Mailing Street 2","Primary Applicant Mailing City","Primary Applicant Mailing State","Primary Applicant Mailing Zip Code","Primary Applicant Work Street","Primary Applicant Work Street 2","Primary Applicant Work City","Primary Applicant Work State","Primary Applicant Work Zip Code","Alternate Contact First Name","Alternate Contact Last Name","Alternate Contact Type","Alternate Contact Agency","Alternate Contact Other Type","Alternate Contact Email Address","Alternate Contact Phone Number","Alternate Contact Street","Alternate Contact Street 2","Alternate Contact City","Alternate Contact State","Alternate Contact Zip Code","Income","Income Period","Accessibility Mobility","Accessibility Vision","Accessibility Hearing","Expecting Household Changes","Household Includes Student or Member Nearing 18","Vouchers or Subsidies","Requested Unit Types","Preference text 0","Program text 1","Household Size","Marked As Duplicate","Flagged As Duplicate","Race","Gender","Sexual Orientation","Spoken Language","How did you Hear?"';
'"Application Id","Application Confirmation Code","Application Type","Application Submission Date","Application Received At","Application Received By","Primary Applicant First Name","Primary Applicant Middle Name","Primary Applicant Last Name","Primary Applicant Birth Day","Primary Applicant Birth Month","Primary Applicant Birth Year","Primary Applicant Email Address","Primary Applicant Phone Number","Primary Applicant Phone Type","Primary Applicant Additional Phone Number","Primary Applicant Street","Primary Applicant Street 2","Primary Applicant City","Primary Applicant State","Primary Applicant Zip Code","Primary Applicant Mailing Street","Primary Applicant Mailing Street 2","Primary Applicant Mailing City","Primary Applicant Mailing State","Primary Applicant Mailing Zip Code","Alternate Contact First Name","Alternate Contact Last Name","Alternate Contact Type","Alternate Contact Agency","Alternate Contact Other Type","Alternate Contact Email Address","Alternate Contact Phone Number","Alternate Contact Street","Alternate Contact Street 2","Alternate Contact City","Alternate Contact State","Alternate Contact Zip Code","Income","Income Period","Accessibility Mobility","Accessibility Vision","Accessibility Hearing","Expecting Household Changes","Household Includes Student or Member Nearing 18","Vouchers or Subsidies","Requested Unit Types","Preference text 0","Program text 1","Household Size","Marked As Duplicate","Flagged As Duplicate","Race","Gender","Sexual Orientation","Spoken Language","How did you Hear?"';
const firstApp =
'"application 0 firstName","application 0 middleName","application 0 lastName","application 0 birthDay","application 0 birthMonth","application 0 birthYear","application 0 emailaddress","application 0 phoneNumber","application 0 phoneNumberType","additionalPhoneNumber 0",,"application 0 applicantAddress street","application 0 applicantAddress street2","application 0 applicantAddress city","application 0 applicantAddress state","application 0 applicantAddress zipCode",,,,,,"application 0 applicantWorkAddress street","application 0 applicantWorkAddress street2","application 0 applicantWorkAddress city","application 0 applicantWorkAddress state","application 0 applicantWorkAddress zipCode",,,,,,,,,,,,,"income 0","per month",,,,"true","true","true","Studio,One Bedroom",,,,,,"Indigenous",,,,"Other"';
'"application 0 firstName","application 0 middleName","application 0 lastName","application 0 birthDay","application 0 birthMonth","application 0 birthYear","application 0 emailaddress","application 0 phoneNumber","application 0 phoneNumberType","additionalPhoneNumber 0","application 0 applicantAddress street","application 0 applicantAddress street2","application 0 applicantAddress city","application 0 applicantAddress state","application 0 applicantAddress zipCode",,,,,,,,,,,,,,,,,,"income 0","per month",,,,"true","true","true","Studio,One Bedroom",,,,,,"Indigenous",,,,"Other"';

const mockedStream = new PassThrough();
exportResponse.getStream().pipe(mockedStream);
Expand Down
24 changes: 0 additions & 24 deletions api/test/unit/utilities/application-export-helpers.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -90,10 +90,6 @@ describe('Testing application export helpers', () => {
path: 'additionalPhoneNumber',
label: 'Primary Applicant Additional Phone Number',
},
{
path: 'contactPreferences',
label: 'Primary Applicant Preferred Contact Type',
},
{
path: 'applicant.applicantAddress.street',
label: `Primary Applicant Street`,
Expand Down Expand Up @@ -134,26 +130,6 @@ describe('Testing application export helpers', () => {
path: 'applicationsMailingAddress.zipCode',
label: `Primary Applicant Mailing Zip Code`,
},
{
path: 'applicant.applicantWorkAddress.street',
label: `Primary Applicant Work Street`,
},
{
path: 'applicant.applicantWorkAddress.street2',
label: `Primary Applicant Work Street 2`,
},
{
path: 'applicant.applicantWorkAddress.city',
label: `Primary Applicant Work City`,
},
{
path: 'applicant.applicantWorkAddress.state',
label: `Primary Applicant Work State`,
},
{
path: 'applicant.applicantWorkAddress.zipCode',
label: `Primary Applicant Work Zip Code`,
},
{
path: 'alternateContact.firstName',
label: 'Alternate Contact First Name',
Expand Down
1 change: 0 additions & 1 deletion doorway-ui-components/src/locales/es.json
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,6 @@
"application.contact.phoneNumberTypes.home": "Casa",
"application.contact.phoneNumberTypes.prompt": "¿Qué tipo de número es este?",
"application.contact.phoneNumberTypes.work": "Trabajo",
"application.contact.preferredContactType": "Tipo de contacto preferido",
"application.contact.provideAMailingAddress": "Proporcione una dirección en donde pueda recibir información actualizada y materiales relacionados con su solicitud.",
"application.contact.sendMailToMailingAddress": "Envíenme mi correspondencia a una dirección diferente",
"application.contact.state": "Estado",
Expand Down
1 change: 0 additions & 1 deletion doorway-ui-components/src/locales/general.json
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,6 @@
"application.contact.phoneNumberTypes.home": "Home",
"application.contact.phoneNumberTypes.prompt": "What type of number is this?",
"application.contact.phoneNumberTypes.work": "Work",
"application.contact.preferredContactType": "Preferred Contact Type",
"application.contact.provideAMailingAddress": "Provide an address where you can receive updates and materials about your application.",
"application.contact.sendMailToMailingAddress": "Send my mail to a different address",
"application.contact.state": "State",
Expand Down
1 change: 0 additions & 1 deletion doorway-ui-components/src/locales/tl.json
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,6 @@
"application.contact.phoneNumberTypes.home": "Home",
"application.contact.phoneNumberTypes.prompt": "Anong uri ng numero ito?",
"application.contact.phoneNumberTypes.work": "Trabaho",
"application.contact.preferredContactType": "Napiling Uri ng Contact",
"application.contact.provideAMailingAddress": "Magbigay ng address kung saan maaari kang tumanggap ng mga update at materyal tungkol sa iyong application.",
"application.contact.sendMailToMailingAddress": "Ipadala ang aking liham sa ibang address",
"application.contact.state": "State",
Expand Down
1 change: 0 additions & 1 deletion doorway-ui-components/src/locales/vi.json
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,6 @@
"application.contact.phoneNumberTypes.home": "Nhà riêng",
"application.contact.phoneNumberTypes.prompt": "Kiểu số điện thoại này là gì?",
"application.contact.phoneNumberTypes.work": "Sở làm",
"application.contact.preferredContactType": "Loại Liên lạc Ưu tiên",
"application.contact.provideAMailingAddress": "Cung cấp địa chỉ nơi quý vị có thể nhận các thông tin cập nhật và tài liệu về đơn ghi danh của mình.",
"application.contact.sendMailToMailingAddress": "Gửi thư của tôi đến một địa chỉ khác",
"application.contact.state": "Tiểu bang",
Expand Down
1 change: 0 additions & 1 deletion doorway-ui-components/src/locales/zh.json
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,6 @@
"application.contact.phoneNumberTypes.home": "住家",
"application.contact.phoneNumberTypes.prompt": "這是哪類電話號碼?",
"application.contact.phoneNumberTypes.work": "工作",
"application.contact.preferredContactType": "首選聯絡方式",
"application.contact.provideAMailingAddress": "請提供一個可收到您最新申請消息和資料的地址。",
"application.contact.sendMailToMailingAddress": "請將我的郵件寄往另一地址",
"application.contact.state": "州",
Expand Down
1 change: 0 additions & 1 deletion shared-helpers/__tests__/testHelpers.ts
Original file line number Diff line number Diff line change
Expand Up @@ -166,7 +166,6 @@ export const application: Application = {
createdAt: new Date(),
updatedAt: new Date(),
},
contactPreferences: [],
preferredUnitTypes: [],
householdMember: [
{
Expand Down
17 changes: 7 additions & 10 deletions shared-helpers/src/locales/es.json
Original file line number Diff line number Diff line change
Expand Up @@ -181,21 +181,18 @@
"application.financial.vouchers.title": "¿Recibe usted o algún miembro de su hogar vales de la sección 8 o emitidos por la Autoridad de Vivienda, incluidos los vales de Vivienda de Apoyo para Asuntos de Veteranos (VASH), o ayuda para el alquiler de otras fuentes?",
"application.form.general.saveAndFinishLater": "Guardar y terminar más tarde",
"application.form.general.saveAndReturn": "Guardar y regresar a revisión",
"application.form.options.relationship.aunt": "Tía",
"application.form.options.relationship.auntUncle": "Tía/Tío",
"application.form.options.relationship.child": "Hijo",
"application.form.options.relationship.cousin": "Primo",
"application.form.options.relationship.friend": "Amigo(a)",
"application.form.options.relationship.grandparent": "Abuelo",
"application.form.options.relationship.greatGrandparent": "Bisabuelo",
"application.form.options.relationship.inLaw": "Pariente político",
"application.form.options.relationship.nephew": "Sobrino",
"application.form.options.relationship.niece": "Sobrina",
"application.form.options.relationship.grandparentGreatGrandparent": "Abuelo/Bisabuelo",
"application.form.options.relationship.nephewNiece": "Sobrino/Sobrina",
"application.form.options.relationship.liveInAide": "Asistente Residente",
"application.form.options.relationship.other": "Otro",
"application.form.options.relationship.parent": "Padre",
"application.form.options.relationship.registeredDomesticPartner": "Pareja de hecho registrada",
"application.form.options.relationship.sibling": "Hermano",
"application.form.options.relationship.spouse": "Cónyuge",
"application.form.options.relationship.uncle": "Tío",
"application.form.options.relationship.girlfriendBoyfriend": "Novia/Novio",
"application.form.options.relationship.brotherSister": "Hermano/Hermana",
"application.form.options.relationship.spousePartner": "Cónyuge/Pareja",
"application.household.addMembers.addHouseholdMember": "+ Añadir miembro del hogar",
"application.household.addMembers.done": "Ya terminó de añadir personas",
"application.household.addMembers.doubleCheck": "Por favor revise la información de cada miembro del hogar.",
Expand Down
Loading
Loading