Replace deprecated utcnow() calls with now(timezone.utc)
#788
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eecavanna
approved these changes
Nov 22, 2024
There was a problem hiding this comment.
I see the deprecation notice in the Python 3 docs:
The changes in this branch are consistent with "the recommended way" shown in the red box on that page.
eecavanna
changed the title
utcnow() calls with now(timezone.utc) (recommended in Python docs)
|
I confirmed that, even in the Python 3.10 docs, this replacement is "recommended." 
The reason I checked that version of the Python docs is that that is the Python version that is running in the container image that runs the FastAPI app, according to its Dockerfile. |
eecavanna
changed the title
utcnow() calls with now(timezone.utc) (recommended in Python docs)utcnow() calls with now(timezone.utc)
|
I'm comfortable with this branch being merged into |
dwinston
pushed a commit
that referenced
this pull request
Nov 26, 2024
dwinston
added a commit
that referenced
this pull request
Nov 26, 2024
…ur with `refscan` (no false positives) (#796) * todo: progress * todo: progress * fix: ThreadPoolExecutor is evil? closes #576 * Drop the old tests2 dir * Update to the newer syntax for getting utcnow() (#788) * Add "Translators" subsystem as option in PR template (#767) * Remove reference to nonexistent `tests2` directory --------- Co-authored-by: shreddd <[email protected]> Co-authored-by: Shreyas Cholia <[email protected]> Co-authored-by: eecavanna <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix to address deprecated datetime.utcnow() calls