Add basic support for Google AI models #1145
Annotations
3 errors
|
genaiscript pr-review-commit:
packages/core/src/chat.ts#L821
The expression `genOptions.logprobs || top_logprobs > 0 ? true : undefined` may not work as intended due to operator precedence. Consider using parentheses to clarify the logic.
|
|
genaiscript pr-review-commit:
packages/core/src/connection.ts#L294
The `base` URL for the Google API is not validated. Consider adding a check to ensure it's a valid URL to prevent potential runtime errors.
|
|
genaiscript pr-review-commit:
packages/core/src/connection.ts#L289
The function `parseTokenFromEnv` for the Google provider does not handle the case where `model` is undefined. Ensure that `model` is defined before returning the configuration.
|
Loading