Skip to content
Back to pull request #868

Add basic support for Google AI models #1145

Sign in to view logs

Add basic support for Google AI models

Add basic support for Google AI models #1145

Triggered via pull request November 17, 2024 11:27
@pelikhanpelikhan
opened #868
googlegemini
Status Success
Total duration 1m 33s
Artifacts 1

genai-pr-commit-review.yml

on: pull_request
build
1m 21s
build
Fit to window
Zoom out
Zoom in

Annotations

3 errors
build: packages/core/src/chat.ts#L821
The expression `genOptions.logprobs || top_logprobs > 0 ? true : undefined` may not work as intended due to operator precedence. Consider using parentheses to clarify the logic.
build: packages/core/src/connection.ts#L294
The `base` URL for the Google API is not validated. Consider adding a check to ensure it's a valid URL to prevent potential runtime errors.
build: packages/core/src/connection.ts#L289
The function `parseTokenFromEnv` for the Google provider does not handle the case where `model` is undefined. Ensure that `model` is defined before returning the configuration.

Artifacts

Produced during runtime
Name Size
genai-results
77.7 KB