Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enhance: move segcore codes of segment into one package #37722

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

enhance: move segcore codes of segment into one package #37722

wants to merge 1 commit into from
+2,398 −858

Conversation

chyezh
Copy link
Contributor

@chyezh chyezh commented Nov 15, 2024

issue: #33285

  • move most cgo opeartions related to search/query into segcore package for reusing for streamingnode.
  • add go unittest for segcore operations.

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: chyezh
To complete the pull request process, please assign wxyucs after the PR has been reviewed.
You can assign the PR to them by writing /assign @wxyucs in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot added size/XXL Denotes a PR that changes 1000+ lines. area/compilation labels Nov 15, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement labels Nov 15, 2024
@chyezh chyezh mentioned this pull request Nov 15, 2024
Open
46 tasks
@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 15, 2024

@chyezh go-sdk check failed, comment rerun go-sdk can trigger the job again.

@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 15, 2024

@chyezh E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@codecov Codecov
Copy link

codecov bot commented Nov 15, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 80.14981% with 106 lines in your changes missing coverage. Please review.

Project coverage is 82.90%. Comparing base (ed73dfc) to head (1fb95a3).
Report is 5 commits behind head on master.

Files with missing lines Patch % Lines
internal/util/segcore/segment.go 79.23% 26 Missing and 12 partials ⚠️
internal/querynodev2/segments/segment.go 86.77% 9 Missing and 7 partials ⚠️
internal/util/segcore/requests.go 69.23% 8 Missing and 4 partials ⚠️
internal/util/segcore/reduce.go 9.09% 5 Missing and 5 partials ⚠️
internal/querynodev2/segments/collection.go 62.50% 4 Missing and 2 partials ⚠️
internal/util/segcore/collection.go 81.25% 4 Missing and 2 partials ⚠️
internal/querynodev2/segments/result.go 16.66% 4 Missing and 1 partial ⚠️
internal/querynodev2/segments/segment_l0.go 0.00% 3 Missing ⚠️
internal/util/segcore/cgo_util.go 88.46% 2 Missing and 1 partial ⚠️
internal/util/segcore/responses.go 75.00% 2 Missing and 1 partial ⚠️
... and 2 more
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #37722      +/-   ##
==========================================
+ Coverage   81.08%   82.90%   +1.82%     
==========================================
  Files        1360     1079     -281     
  Lines      190775   165406   -25369     
==========================================
- Hits       154686   137127   -17559     
+ Misses      30612    22784    -7828     
- Partials     5477     5495      +18
Components Coverage Δ
Client 72.33% <ø> (ø)
Core ∅ <ø> (∅)
Go 83.19% <80.14%> (-0.07%) ⬇️
Files with missing lines Coverage Δ
internal/querynodev2/segments/cgo_util.go 28.57% <ø> (-52.51%) ⬇️
internal/querynodev2/segments/count_reducer.go 100.00% <100.00%> (ø)
internal/querynodev2/segments/reducer.go 90.90% <ø> (ø)
internal/querynodev2/segments/retrieve.go 82.40% <100.00%> (ø)
internal/querynodev2/segments/search.go 63.47% <100.00%> (ø)
internal/querynodev2/segments/segcore.go 100.00% <100.00%> (ø)
internal/querynodev2/segments/segment_loader.go 72.74% <100.00%> (-0.49%) ⬇️
internal/querynodev2/server.go 77.62% <100.00%> (ø)
internal/querynodev2/tasks/query_stream_task.go 79.16% <100.00%> (-0.43%) ⬇️
internal/querynodev2/tasks/query_task.go 90.17% <100.00%> (-0.09%) ⬇️
... and 14 more

... and 327 files with indirect coverage changes

---- 🚨 Try these New Features:

@chyezh chyezh force-pushed the enhance_move_general_usage_of_search branch 2 times, most recently from 6a0623c to 2f92e55 Compare November 17, 2024 02:16
@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 17, 2024

@chyezh E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@chyezh chyezh force-pushed the enhance_move_general_usage_of_search branch from 2f92e55 to 9d6f946 Compare November 17, 2024 04:54
@mergify mergify bot added the ci-passed label Nov 17, 2024
This was referenced Nov 21, 2024
Open
Merged
czs007 pushed a commit that referenced this pull request Nov 21, 2024
@chyezh
enhance: remove the rpc level of coordinator (#37876)
1a6b98b 
issue: #33285
pr: #37722

- move most cgo opeartions related to search/query into segcore package
for reusing for streamingnode.
- add go unittest for segcore operations.

Signed-off-by: chyezh <[email protected]>
@chyezh chyezh force-pushed the enhance_move_general_usage_of_search branch from 9d6f946 to 9348b52 Compare November 21, 2024 07:54
@mergify mergify bot removed the ci-passed label Nov 21, 2024
@chyezh chyezh force-pushed the enhance_move_general_usage_of_search branch from 9348b52 to 7e3e8be Compare November 22, 2024 09:58
@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 22, 2024

@chyezh go-sdk check failed, comment rerun go-sdk can trigger the job again.

@chyezh chyezh force-pushed the enhance_move_general_usage_of_search branch from 7e3e8be to 5eafb38 Compare November 24, 2024 07:20
@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 24, 2024

@chyezh go-sdk check failed, comment rerun go-sdk can trigger the job again.

@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 24, 2024

@chyezh E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@chyezh
enhance: move segcore codes of segment into one package
1fb95a3 
- move most cgo opeartion related to search/query into segcore package
  for reusing for streamingnode.
- add go unittest for segcore operations.

Signed-off-by: chyezh <[email protected]>
@chyezh chyezh force-pushed the enhance_move_general_usage_of_search branch from 5eafb38 to 1fb95a3 Compare November 25, 2024 02:39
@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 25, 2024

@chyezh go-sdk check failed, comment rerun go-sdk can trigger the job again.

@chyezh
Copy link
Contributor Author

chyezh commented Nov 25, 2024

rerun go-sdk

@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 25, 2024

@chyezh cpp-unit-test check failed, comment rerun cpp-unit-test can trigger the job again.

@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 25, 2024

@chyezh E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@chyezh
Copy link
Contributor Author

chyezh commented Nov 25, 2024

/run-cpu-e2e

@chyezh
Copy link
Contributor Author

chyezh commented Nov 25, 2024

rerun cpp-unit-test

@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 25, 2024

@chyezh cpp-unit-test check failed, comment rerun cpp-unit-test can trigger the job again.

bigsheeper pushed a commit to bigsheeper/milvus that referenced this pull request Nov 25, 2024
@chyezh @bigsheeper
enhance: remove the rpc level of coordinator (milvus-io#37876)
e6a273a 
issue: milvus-io#33285
pr: milvus-io#37722

- move most cgo opeartions related to search/query into segcore package
for reusing for streamingnode.
- add go unittest for segcore operations.

Signed-off-by: chyezh <[email protected]>
@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 25, 2024

@chyezh E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@chyezh
Copy link
Contributor Author

chyezh commented Nov 25, 2024

/run-cpu-e2e

@chyezh
Copy link
Contributor Author

chyezh commented Nov 25, 2024

rerun cpp-unit-test

1 similar comment
@chyezh
Copy link
Contributor Author

chyezh commented Nov 25, 2024

rerun cpp-unit-test

@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 25, 2024

@chyezh E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@chyezh
Copy link
Contributor Author

chyezh commented Nov 25, 2024

/run-cpu-e2e

@chyezh
Copy link
Contributor Author

chyezh commented Nov 25, 2024

rerun cpp-unit-test

1 similar comment
@chyezh
Copy link
Contributor Author

chyezh commented Nov 25, 2024

rerun cpp-unit-test

@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 25, 2024

@chyezh cpp-unit-test check failed, comment rerun cpp-unit-test can trigger the job again.

@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 25, 2024

@chyezh E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aoiasd aoiasd Awaiting requested review from aoiasd

@bigsheeper bigsheeper Awaiting requested review from bigsheeper

Assignees
No one assigned
Labels
area/compilation dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement size/XXL Denotes a PR that changes 1000+ lines.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chyezh @sre-ci-robot