Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: remove the rpc level of coordinator #37876

Merged

Conversation

chyezh
Copy link
Contributor

@chyezh chyezh commented Nov 21, 2024

issue: #33285
pr: #37722

  • move most cgo opeartions related to search/query into segcore package for reusing for streamingnode.
  • add go unittest for segcore operations.

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: chyezh
To complete the pull request process, please assign xiaofan-luan after the PR has been reviewed.
You can assign the PR to them by writing /assign @xiaofan-luan in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines. label Nov 21, 2024
@bigsheeper bigsheeper added the 10kcp PR related to 10k collection partitions Project label Nov 21, 2024
@czs007 czs007 merged commit 1a6b98b into milvus-io:10kcp Nov 21, 2024
10 of 12 checks passed
Copy link

codecov bot commented Nov 21, 2024

Codecov Report

Attention: Patch coverage is 96.83210% with 30 lines in your changes missing coverage. Please review.

Project coverage is 80.73%. Comparing base (0bd2617) to head (18485f0).
Report is 7 commits behind head on 10kcp.

Files with missing lines Patch % Lines
internal/coordinator/coordclient/rootcoord.go 92.68% 24 Missing ⚠️
internal/coordinator/coordclient/registry.go 88.88% 3 Missing and 3 partials ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##            10kcp   #37876      +/-   ##
==========================================
+ Coverage   80.63%   80.73%   +0.10%     
==========================================
  Files        1069     1074       +5     
  Lines      166978   167906     +928     
==========================================
+ Hits       134643   135560     +917     
- Misses      27930    27949      +19     
+ Partials     4405     4397       -8     
Files with missing lines Coverage Δ
internal/coordinator/coordclient/datacoord.go 100.00% <100.00%> (ø)
internal/coordinator/coordclient/querycoord.go 100.00% <100.00%> (ø)
internal/datacoord/server.go 72.52% <100.00%> (ø)
internal/distributed/datacoord/service.go 88.21% <100.00%> (+0.04%) ⬆️
internal/distributed/querycoord/service.go 79.02% <100.00%> (+1.98%) ⬆️
internal/distributed/rootcoord/service.go 81.08% <100.00%> (+0.88%) ⬆️
pkg/util/syncutil/future.go 100.00% <100.00%> (ø)
internal/coordinator/coordclient/registry.go 88.88% <88.88%> (ø)
internal/coordinator/coordclient/rootcoord.go 92.68% <92.68%> (ø)

... and 36 files with indirect coverage changes

---- 🚨 Try these New Features:

bigsheeper added a commit to bigsheeper/milvus that referenced this pull request Nov 21, 2024
bigsheeper pushed a commit to bigsheeper/milvus that referenced this pull request Nov 25, 2024
issue: milvus-io#33285
pr: milvus-io#37722

- move most cgo opeartions related to search/query into segcore package
for reusing for streamingnode.
- add go unittest for segcore operations.

Signed-off-by: chyezh <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
10kcp PR related to 10k collection partitions Project size/XXL Denotes a PR that changes 1000+ lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants