Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DX-2411 Add a warning about expiring cookies #193

Merged
merged 3 commits into from
Sep 18, 2023
Merged

DX-2411 Add a warning about expiring cookies #193

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4d36ee5
DX-2411 Add a warning about expiring cookies
kirillsud Sep 14, 2023
036392e
Add a screenshot about how to delete a cookie
kirillsud Sep 14, 2023
61cb12f
typo in README.md
kirillsud Sep 14, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Binary file added assets/devtools-cookie-delete.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
8 changes: 8 additions & 0 deletions examples/nextjs-full-stack/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,6 +60,14 @@ Once your server is up and running:
2. Open a board in your Developer team.
3. To start the app, click the corresponding app icon in the app toolbar on the left.

> ⚠️ In case of error `401` returned by a REST API request, remove the `miro_tokens` cookie for the `localhost`
> domain in the browser:
>
> <img alt="Chrome's DevTools cookies delete" src="https://github.com/miroapp/app-examples/raw/main/assets/devtools-cookie-delete.png" />
>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it possible to add either a screenshot / explanation of how to do that? I'm still not sure myself, so I think some devs maybe will not how to remove cookies for localhost specifically.

*typo in localhsot

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it

Chrome -> Settings -> Privacy and Security -> Clear browsing data? I think this is not right.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, it depends on the browser. For example, we can add a screenshot for Chrome's DevTools:

image

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great to me!

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually one small typo for localhost in line 63 @kirillsud

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screenshot 2023-09-14 at 13 31 38

What is a bit strange is I dont have any cookies for localhost and I still see the 401 error

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry please ignore now I do see them

> In the example, the access token refresh functionality has not been implemented to keep the implementation
> simple and focused on the topic.

## Folder structure

```
Expand Down
Loading