-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(sdk): improvement of build-in process to delete nodes #45
Conversation
Library Vulnerability scan resultsThe following vulnerabilities have been found in libraries included in the repository (some might be dependencies of dependencies). Critical 🔴 and High 🟡 severity vulnerabilities must be fixed before the PR can be merged, even if they are dependencies of dependencies.
|
Library Vulnerability scan resultsThe following vulnerabilities have been found in libraries included in the repository (some might be dependencies of dependencies). Critical 🔴 and High 🟡 severity vulnerabilities must be fixed before the PR can be merged, even if they are dependencies of dependencies.
|
Library Vulnerability scan resultsThe following vulnerabilities have been found in libraries included in the repository (some might be dependencies of dependencies). Critical 🔴 and High 🟡 severity vulnerabilities must be fixed before the PR can be merged, even if they are dependencies of dependencies.
|
…ery-product-by-id
Library Vulnerability scan resultsThe following vulnerabilities have been found in libraries included in the repository (some might be dependencies of dependencies). Critical 🔴 and High 🟡 severity vulnerabilities must be fixed before the PR can be merged, even if they are dependencies of dependencies.
|
Library Vulnerability scan resultsThe following vulnerabilities have been found in libraries included in the repository (some might be dependencies of dependencies). Critical 🔴 and High 🟡 severity vulnerabilities must be fixed before the PR can be merged, even if they are dependencies of dependencies.
|
Quality Gate passedIssues Measures |
…ery-product-by-id
Library Vulnerability scan resultsThe following vulnerabilities have been found in libraries included in the repository (some might be dependencies of dependencies). Critical 🔴 and High 🟡 severity vulnerabilities must be fixed before the PR can be merged, even if they are dependencies of dependencies.
|
…ery-product-by-id
Library Vulnerability scan resultsThe following vulnerabilities have been found in libraries included in the repository (some might be dependencies of dependencies). Critical 🔴 and High 🟡 severity vulnerabilities must be fixed before the PR can be merged, even if they are dependencies of dependencies.
|
Library Vulnerability scan resultsThe following vulnerabilities have been found in libraries included in the repository (some might be dependencies of dependencies). Critical 🔴 and High 🟡 severity vulnerabilities must be fixed before the PR can be merged, even if they are dependencies of dependencies.
|
…ery-product-by-id
…/kraken into fix/fix-query-product-by-id
Library Vulnerability scan resultsThe following vulnerabilities have been found in libraries included in the repository (some might be dependencies of dependencies). Critical 🔴 and High 🟡 severity vulnerabilities must be fixed before the PR can be merged, even if they are dependencies of dependencies.
|
Library Vulnerability scan resultsThe following vulnerabilities have been found in libraries included in the repository (some might be dependencies of dependencies). Critical 🔴 and High 🟡 severity vulnerabilities must be fixed before the PR can be merged, even if they are dependencies of dependencies.
|
Library Vulnerability scan resultsThe following vulnerabilities have been found in libraries included in the repository (some might be dependencies of dependencies). Critical 🔴 and High 🟡 severity vulnerabilities must be fixed before the PR can be merged, even if they are dependencies of dependencies.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
- classpath:/mock/mapping-matrix/mapping.matrix.quote.yaml | ||
- classpath:/mock/mapping-matrix/mapping.matrix.address.validation.yaml | ||
|
||
#- classpath:/mock/api-targets-mappers/api-target-mapper.inventory.eline.list.yaml |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please consider to remove commented out code
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Inventory is in use now. So this line will be reserved for fast testing in future.
kind: kraken.component.api-target | ||
apiVersion: v1 | ||
metadata: | ||
key: mef.sonata.api-target.order.notification.state.change |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please remove this file if it is useless
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. This file has been deleted.
kind: kraken.component.api-target | ||
apiVersion: v1 | ||
metadata: | ||
key: mef.sonata.api-target.poq.notification.state.change |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same with above
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. This file has been deleted.
@@ -5,6 +5,7 @@ metadata: | |||
key: mef.sonata.api-target.poq.eline.add | |||
name: Product Offering Qualification (POQ) API | |||
mapperKey: mef.sonata.api-target-mapper.poq.eline.add | |||
version: 1 | |||
spec: | |||
inputs: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same with above
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. This file has been deleted.
#- classpath:/mock/api-targets-mappers/api-target-mapper.inventory.eline.list.yaml |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Consider to remove commented out code.
Library Vulnerability scan resultsThe following vulnerabilities have been found in libraries included in the repository (some might be dependencies of dependencies). Critical 🔴 and High 🟡 severity vulnerabilities must be fixed before the PR can be merged, even if they are dependencies of dependencies.
|
Quality Gate passed for 'kraken_nodejs'Issues Measures |
Quality Gate passed for 'kraken_java'Issues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description
Added improvement of build-in process to delete nodes with a null value in inventory response
Related Issue
#34
Motivation and Context
How This Has Been Tested
Integration test in localhost
Screenshots (if appropriate)
Types of changes
Checklist