Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(sdk): improvement of build-in process to delete nodes #45

Merged
merged 14 commits into from
Nov 4, 2024

Conversation

xuelianhan007
Copy link
Contributor

@xuelianhan007 xuelianhan007 commented Oct 31, 2024

Description

Added improvement of build-in process to delete nodes with a null value in inventory response

Related Issue

#34

Motivation and Context

How This Has Been Tested

Integration test in localhost

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Refactoring or add test (improvements in base code or adds test coverage to functionality)
  • CI/CD or documentation update (changes to CI/CD pipeline or documentation)

Checklist

  • I ensured that the documentation is up to date
  • I explained why this PR updates in detail with reasoning why it's required
  • I would like a code coverage CI quality gate exception and have explained why

Copy link
Contributor

Library Vulnerability scan results

The following vulnerabilities have been found in libraries included in the repository (some might be dependencies of dependencies).

Critical 🔴 and High 🟡 severity vulnerabilities must be fixed before the PR can be merged, even if they are dependencies of dependencies.

Library Vulnerable version Severity Fix version Vulnerability ID

@xuelianhan007 xuelianhan007 changed the title Added improvement of build-in process to delete nodes with a null val… fix(sdk): improvement of build-in process to delete nodes with a null val… Nov 1, 2024
@xuelianhan007 xuelianhan007 changed the title fix(sdk): improvement of build-in process to delete nodes with a null val… fix(sdk): improvement of build-in process to delete nodes Nov 1, 2024
Copy link
Contributor

github-actions bot commented Nov 1, 2024

Library Vulnerability scan results

The following vulnerabilities have been found in libraries included in the repository (some might be dependencies of dependencies).

Critical 🔴 and High 🟡 severity vulnerabilities must be fixed before the PR can be merged, even if they are dependencies of dependencies.

Library Vulnerable version Severity Fix version Vulnerability ID

Copy link
Contributor

github-actions bot commented Nov 1, 2024

Library Vulnerability scan results

The following vulnerabilities have been found in libraries included in the repository (some might be dependencies of dependencies).

Critical 🔴 and High 🟡 severity vulnerabilities must be fixed before the PR can be merged, even if they are dependencies of dependencies.

Library Vulnerable version Severity Fix version Vulnerability ID

Copy link
Contributor

github-actions bot commented Nov 1, 2024

Library Vulnerability scan results

The following vulnerabilities have been found in libraries included in the repository (some might be dependencies of dependencies).

Critical 🔴 and High 🟡 severity vulnerabilities must be fixed before the PR can be merged, even if they are dependencies of dependencies.

Library Vulnerable version Severity Fix version Vulnerability ID

Copy link
Contributor

github-actions bot commented Nov 1, 2024

Library Vulnerability scan results

The following vulnerabilities have been found in libraries included in the repository (some might be dependencies of dependencies).

Critical 🔴 and High 🟡 severity vulnerabilities must be fixed before the PR can be merged, even if they are dependencies of dependencies.

Library Vulnerable version Severity Fix version Vulnerability ID

Copy link

sonarqubecloud bot commented Nov 1, 2024

Copy link
Contributor

github-actions bot commented Nov 1, 2024

Library Vulnerability scan results

The following vulnerabilities have been found in libraries included in the repository (some might be dependencies of dependencies).

Critical 🔴 and High 🟡 severity vulnerabilities must be fixed before the PR can be merged, even if they are dependencies of dependencies.

Library Vulnerable version Severity Fix version Vulnerability ID

@xuelianhan007 xuelianhan007 requested a review from a team as a code owner November 1, 2024 08:20
Copy link
Contributor

github-actions bot commented Nov 1, 2024

Library Vulnerability scan results

The following vulnerabilities have been found in libraries included in the repository (some might be dependencies of dependencies).

Critical 🔴 and High 🟡 severity vulnerabilities must be fixed before the PR can be merged, even if they are dependencies of dependencies.

Library Vulnerable version Severity Fix version Vulnerability ID

Copy link
Contributor

github-actions bot commented Nov 1, 2024

Library Vulnerability scan results

The following vulnerabilities have been found in libraries included in the repository (some might be dependencies of dependencies).

Critical 🔴 and High 🟡 severity vulnerabilities must be fixed before the PR can be merged, even if they are dependencies of dependencies.

Library Vulnerable version Severity Fix version Vulnerability ID

Copy link
Contributor

github-actions bot commented Nov 1, 2024

Library Vulnerability scan results

The following vulnerabilities have been found in libraries included in the repository (some might be dependencies of dependencies).

Critical 🔴 and High 🟡 severity vulnerabilities must be fixed before the PR can be merged, even if they are dependencies of dependencies.

Library Vulnerable version Severity Fix version Vulnerability ID

Copy link
Contributor

github-actions bot commented Nov 4, 2024

Library Vulnerability scan results

The following vulnerabilities have been found in libraries included in the repository (some might be dependencies of dependencies).

Critical 🔴 and High 🟡 severity vulnerabilities must be fixed before the PR can be merged, even if they are dependencies of dependencies.

Library Vulnerable version Severity Fix version Vulnerability ID

@xuelianhan007 xuelianhan007 reopened this Nov 4, 2024
Copy link
Contributor

github-actions bot commented Nov 4, 2024

Library Vulnerability scan results

The following vulnerabilities have been found in libraries included in the repository (some might be dependencies of dependencies).

Critical 🔴 and High 🟡 severity vulnerabilities must be fixed before the PR can be merged, even if they are dependencies of dependencies.

Library Vulnerable version Severity Fix version Vulnerability ID

Copy link
Contributor

@kuangxiang20240501 kuangxiang20240501 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

- classpath:/mock/mapping-matrix/mapping.matrix.quote.yaml
- classpath:/mock/mapping-matrix/mapping.matrix.address.validation.yaml

#- classpath:/mock/api-targets-mappers/api-target-mapper.inventory.eline.list.yaml
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please consider to remove commented out code

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Inventory is in use now. So this line will be reserved for fast testing in future.

kind: kraken.component.api-target
apiVersion: v1
metadata:
key: mef.sonata.api-target.order.notification.state.change
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove this file if it is useless

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. This file has been deleted.

kind: kraken.component.api-target
apiVersion: v1
metadata:
key: mef.sonata.api-target.poq.notification.state.change
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same with above

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. This file has been deleted.

@@ -5,6 +5,7 @@ metadata:
key: mef.sonata.api-target.poq.eline.add
name: Product Offering Qualification (POQ) API
mapperKey: mef.sonata.api-target-mapper.poq.eline.add
version: 1
spec:
inputs:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same with above

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. This file has been deleted.

#- classpath:/mock/api-targets-mappers/api-target-mapper.inventory.eline.list.yaml
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider to remove commented out code.

Copy link
Contributor

github-actions bot commented Nov 4, 2024

Library Vulnerability scan results

The following vulnerabilities have been found in libraries included in the repository (some might be dependencies of dependencies).

Critical 🔴 and High 🟡 severity vulnerabilities must be fixed before the PR can be merged, even if they are dependencies of dependencies.

Library Vulnerable version Severity Fix version Vulnerability ID

Copy link

sonarqubecloud bot commented Nov 4, 2024

Copy link

sonarqubecloud bot commented Nov 4, 2024

Copy link
Contributor

@zhiyaoPCCW zhiyaoPCCW left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@xuelianhan007 xuelianhan007 merged commit e1912fb into main Nov 4, 2024
6 checks passed
@xuelianhan007 xuelianhan007 deleted the fix/fix-query-product-by-id branch November 4, 2024 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants