-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(sdk): improvement of build-in process to delete nodes #45
Merged
Merged
Changes from all commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
54803c0
Added improvement of build-in process to delete nodes with a null val…
xuelianhan007 8926751
reserve some default configurations
xuelianhan007 2c160ad
fix unit test
xuelianhan007 38541db
format codes
xuelianhan007 06a91fb
Merge branch 'main' of github.com:mycloudnexus/kraken into fix/fix-qu…
xuelianhan007 47628ae
merge with the main branch
xuelianhan007 8c542b3
remove test configurations
xuelianhan007 0f42122
Merge branch 'main' of github.com:mycloudnexus/kraken into fix/fix-qu…
xuelianhan007 4c02dfc
Merge branch 'main' of github.com:mycloudnexus/kraken into fix/fix-qu…
xuelianhan007 5272cde
Merge branch 'main' into fix/fix-query-product-by-id
DaveXiong e7b5353
Merge branch 'main' of github.com:mycloudnexus/kraken into fix/fix-qu…
xuelianhan007 06780c7
added unit tests
xuelianhan007 2ed5884
Merge branch 'fix/fix-query-product-by-id' of github.com:mycloudnexus…
xuelianhan007 7ba23f5
delete not used files
xuelianhan007 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
20 changes: 0 additions & 20 deletions
20
...ken-app-hub/src/main/resources/mock/mapping-matrix/mapping.matrix.address.validation.yaml
This file was deleted.
Oops, something went wrong.
40 changes: 0 additions & 40 deletions
40
kraken-app/kraken-app-hub/src/main/resources/mock/mapping-matrix/mapping.matrix.order.yaml
This file was deleted.
Oops, something went wrong.
69 changes: 0 additions & 69 deletions
69
kraken-app/kraken-app-hub/src/main/resources/mock/mapping-matrix/mapping.matrix.quote.yaml
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 changes: 3 additions & 2 deletions
5
kraken-app/kraken-app-hub/src/test/resources/expected/expected-2-address.retrieve.json
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,9 +1,10 @@ | ||
| { | ||
| "id": "${responseBody.id}", | ||
| "type": "FieldedAddress", | ||
| "@type": "FieldedAddress", | ||
| "associatedGeographicAddress": { | ||
| "country": "${responseBody.company.addresses[0].country}", | ||
| "city": "${responseBody.company.addresses[0].city}", | ||
| "streetName": "${responseBody.company.addresses[0].address}" | ||
| "streetName": "${responseBody.company.addresses[0].address}", | ||
| "locality": "${responseBody.associatedGeographicAddress.locality}" | ||
| } | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8 changes: 4 additions & 4 deletions
8
kraken-app/kraken-app-hub/src/test/resources/expected/expected-order.json
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,9 +1,9 @@ | ||
| { | ||
| "relatedContactInformation": "${T(com.consoleconnect.kraken.operator.gateway.func.SpelFunc).appendSellerInformation(env.seller.role, env.seller.name, env.seller.emailAddress, env.seller.number, mefRequestBody.relatedContactInformation)}", | ||
| "relatedContactInformation": "${T(com.consoleconnect.kraken.operator.gateway.func.SpelFunc).appendSellerInformation(env.seller.role,env.seller.name,env.seller.emailAddress,env.seller.number,mefRequestBody.relatedContactInformation)}", | ||
| "id": "${entity.id}", | ||
| "orderDate": "function.now()", | ||
| "orderDate": "${T(com.consoleconnect.kraken.operator.core.toolkit.DateTime).nowInUTCFormatted()}", | ||
| "productOrderItem": "${mefRequestBody.productOrderItem}", | ||
| "state": "${responseBody.status}", | ||
| "orderId":"${responseBody.id}", | ||
| "instanceId":"${responseBody.port.id}" | ||
| "orderId": "${responseBody.id}", | ||
| "instanceId": "${responseBody.port.id}" | ||
| } |
29 changes: 29 additions & 0 deletions
29
kraken-app/kraken-app-hub/src/test/resources/expected/expected-quote.eline.add.json
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,29 @@ | ||
| { | ||
| "id": "${entity.id}", | ||
| "relatedContactInformation": "${T(com.consoleconnect.kraken.operator.gateway.func.SpelFunc).appendSellerInformation('sellerContactInformation',env.seller.name,env.seller.emailAddress,env.seller.number,mefRequestBody.relatedContactInformation)}", | ||
| "buyerRequestedQuoteLevel": "${mefRequestBody.buyerRequestedQuoteLevel}", | ||
| "quoteItem": [ | ||
| { | ||
| "quoteItem": "${mefRequestBody.quoteItem[0].requestedQuoteItemTerm}}", | ||
| "requestedQuoteItemTerm": "${mefRequestBody.quoteItem[0].requestedQuoteItemTerm}}", | ||
| "product": "${mefRequestBody.quoteItem[0].product}", | ||
| "state": "answered", | ||
| "quoteItemPrice": [ | ||
| { | ||
| "price": { | ||
| "dutyFreeAmount": { | ||
| "unit": "USD", | ||
| "value": "${responseBody.results[0].price}" | ||
| } | ||
| } | ||
| } | ||
| ] | ||
| } | ||
| ], | ||
| "quoteDate": "${T(com.consoleconnect.kraken.operator.core.toolkit.DateTime).nowInUTCFormatted()}", | ||
| "externalId": "${mefRequestBody[externalId]?:''}", | ||
| "instantSyncQuote": "${mefRequestBody[instantSyncQuote]?:''}", | ||
| "requestedQuoteCompletionDate": "${mefRequestBody[requestedQuoteCompletionDate]?:''}", | ||
| "quoteLevel": "${mefRequestBody.buyerRequestedQuoteLevel}", | ||
| "state": "((mefResponseBody.quoteItem[0].quoteItemPrice[0].price.dutyFreeAmount.value==''?'unableToProvide':'approved.orderable'))" | ||
| } |
24 changes: 0 additions & 24 deletions
24
kraken-app/kraken-app-hub/src/test/resources/expected/expected-quote.json
This file was deleted.
Oops, something went wrong.
29 changes: 29 additions & 0 deletions
29
kraken-app/kraken-app-hub/src/test/resources/expected/expected-quote.uni.add.json
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,29 @@ | ||
| { | ||
| "id": "${entity.id}", | ||
| "buyerRequestedQuoteLevel": "${mefRequestBody.buyerRequestedQuoteLevel}", | ||
| "relatedContactInformation": "${T(com.consoleconnect.kraken.operator.gateway.func.SpelFunc).appendSellerInformation('sellerContactInformation',env.seller.name,env.seller.emailAddress,env.seller.number,mefRequestBody.relatedContactInformation)}", | ||
| "quoteItem": [ | ||
| { | ||
| "quoteItem": "${mefRequestBody.quoteItem[0].requestedQuoteItemTerm}}", | ||
| "requestedQuoteItemTerm": "${mefRequestBody.quoteItem[0].requestedQuoteItemTerm}}", | ||
| "product": "${mefRequestBody.quoteItem[0].product}", | ||
| "state": "answered", | ||
| "quoteItemPrice": [ | ||
| { | ||
| "price": { | ||
| "dutyFreeAmount": { | ||
| "unit": "USD", | ||
| "value": "${responseBody.results[0].price}" | ||
| } | ||
| } | ||
| } | ||
| ] | ||
| } | ||
| ], | ||
| "quoteDate": "${T(com.consoleconnect.kraken.operator.core.toolkit.DateTime).nowInUTCFormatted()}", | ||
| "externalId": "${mefRequestBody[externalId]?:''}", | ||
| "instantSyncQuote": "${mefRequestBody[instantSyncQuote]?:''}", | ||
| "requestedQuoteCompletionDate": "${mefRequestBody[requestedQuoteCompletionDate]?:''}", | ||
| "quoteLevel": "${mefRequestBody.buyerRequestedQuoteLevel}", | ||
| "state": "((mefResponseBody.quoteItem[0].quoteItemPrice[0].price.dutyFreeAmount.value==''?'unableToProvide':'approved.orderable'))" | ||
| } |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please consider to remove commented out code
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Inventory is in use now. So this line will be reserved for fast testing in future.