Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: fix function names after rename #194

Merged
merged 1 commit into from
Dec 19, 2023

Conversation

bsipocz
Copy link
Member

@bsipocz bsipocz commented Dec 16, 2023

Some of the functions unfortunately got renamed in one of the refactoring PRs, but the code that used the functions hasn't been updated.

note: the rename is unfortunate as now the functions don't follow the standard, all lowercase snake_case naming convention of python functions.

@bsipocz bsipocz added the bug Something isn't working label Dec 16, 2023
@bsipocz bsipocz requested a review from jkrick December 16, 2023 05:29
Copy link
Contributor

@jkrick jkrick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry that was probably me changing the names to keep upper/lower case names consistent between all function calls.

This looks fine to me.

Does this fix the problem of ML_AGNzoo running through to completion?

@bsipocz
Copy link
Member Author

bsipocz commented Dec 19, 2023

Yes, ML_AGNzoo runs through completion for me, but I suppose the doesn't converge issue is still around (at least the plots doesn't look particularly good to me). See more comments about what I found in the slack DM, tldr I don't think it's an issue in my rebase/cleanup of the markdown but due to changes in the code files in code_src.

@bsipocz bsipocz merged commit 9c33d20 into nasa-fornax:main Dec 19, 2023
1 check passed
github-actions bot pushed a commit that referenced this pull request Dec 20, 2023
@bsipocz bsipocz deleted the BUG_fix_function_names branch December 20, 2023 21:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants