Catch specific exceptions in Herschel_get_spec #294
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jkrick
approved these changes
Jul 31, 2024
There was a problem hiding this comment.
This works for me in the sense that the Herschel module runs to completion. Thanks for looking into it.
Since I ran it just now, can you please edit the main notebook Herschel cell:
"#This search is fully functional, but is commented out because it is very slow." to "#This search is fully functional, but is commented out because it takes ~4 hours to run to completion" I ran it on the ISP, so can't really say on Fornax, or specify the server, but I am imagining they will be similar since the data source is the same. We can update this in the future if anyone runs it on Fornax.
github-actions bot
pushed a commit
that referenced
this pull request
Aug 2, 2024
* catch specific exceptions * update comment from jkrick review f16c102
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #282
I added the specific exceptions I ran into so this is no longer a bare
except.