Refactor: notifications

[syphax-bouazzouni]

Changes :

• Add the ui_name config variable (by default set to Bioportal), to fix and replace the hardcoded "Bioportal" in the notification content (email notification hardcoded Bioportal team ontoportal-lirmm/ontologies_linked_data#21)
• Fix the hardcoded notifications mail contact us link, redirecting to [email protected] (email notification of contact us change to [email protected] ontoportal-lirmm/ontologies_linked_data#4)
• Submission process notification is not working (submission notification is not working ontoportal-lirmm/ontologies_linked_data#8)
• Adding 2 new notifications : new_user and new_ontology notifications
• Refactor the code to extract the "Notifier" (in charge of sending the mails) of "Notifications" the content
• Changing the recipients of the notifications:
  • new_note => notify subscribed to the ontology(separately) (note: ontology administrators are not subscribed by default?)
  • submission_processed => notify subscribed(separately) + ontology_adminstrators and support mails (all grouped)(changed: added support and ontology_adminstrators mails)
  • remote_ontology_pull => notify ontology_adminstrators and support mails (all grouped)
  • new_user => notify support mails (grouped)
  • new_ontology => notify support mails (grouped)
  • reset_password => notify the user that is resetting its password
  • obofoundry_sync => notify the support mails (grouped)
• Include Fix: login auth type mail options ontoportal/ontologies_linked_data#9

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ No coverage uploaded for pull request base (master@fc90752). Click here to learn what that means.

Additional details and impacted files

@@            Coverage Diff            @@
##             master     #148   +/-   ##
=========================================
  Coverage          ?   80.66%           
=========================================
  Files             ?       64           
  Lines             ?     4959           
  Branches          ?        0           
=========================================
  Hits              ?     4000           
  Misses            ?      959           
  Partials          ?        0           

Flag	Coverage Δ
unittests	80.66% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[alexskr]

This refactor of notifications is highly valuable and useful.

The BioPortal team acknowledges the potential value in receiving notifications for new user/ontology additions. However, BioPortal does not curate ontologies, so such notifications could potentially generate unnecessary noise. Having an option to disable these specific notifications send to the support email would be greatly appreciated.

Ideally there should be an option for ontology admins to opt in/out of the notifications when ontology is processed/pull fails.

[alexskr]

This PR introduces a new configuration variable LinkedData.settings.admin_emails to enable notifications sent to OntoPortal Administrators, addressing the necessity of replacing hard-coded email addresses.

However, upon deployment in BioPortal, this change will result in end users receiving emails requesting them to contact administrators of BioPortal instead of the expected support email list. To mitigate this, it might be necessary to introduce a secondary configuration option, something equivalent to $SUPPORT_EMAIL in the UI. This new option would serve to differentiate between contacting support and contacting administrators unless BioPortal team chooses to change the default method of contacting support for these kind of notifications.

[alexskr]

merged PR into pr-refacotor-notification branch instead of master. We need to do additional tests and make a few minor tweaks before merging it into master.