neonvm: revert crictl patches #1054
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Omrigan
force-pushed
the
oleg/revert-crictl
branch
3 times, most recently
from
728ab37 to
fcc5f64
Compare
Omrigan
force-pushed
the
oleg/revert-crictl
branch
from
788b5b4 to
1ff1fd0
Compare
Omrigan
force-pushed
the
oleg/revert-crictl
branch
from
454070e to
23e9957
Compare
This reverts commit 95caab1. Signed-off-by: Oleg Vasilev <[email protected]>
Omrigan
force-pushed
the
oleg/revert-crictl
branch
from
23e9957 to
a7fbb7a
Compare
sharnoff
reviewed
Sep 25, 2024
Comment on lines
-16
to
-17
| - type: Degraded | ||
| status: "True" |
There was a problem hiding this comment.
Hmm... I am not actually sure. For some reason, when I apply 3e6da9c, status conditions stop updating. Any idea why it might be the case?
There was a problem hiding this comment.
from discussion: plan is to fix our usage of status conditions in a separate PR
| @@ -33,12 +22,10 @@ RUN apk add --no-cache \ | |||
| e2fsprogs \ | |||
| qemu-system-x86_64 \ | |||
| qemu-img \ | |||
| cgroup-tools \ | |||
| cgroup-tools \ | |||
There was a problem hiding this comment.
unintended diff? (replaces spaces with a tab; unlike the rest of the block)
There was a problem hiding this comment.
It's unrelated, but intended. Do you want me to split it off?
There was a problem hiding this comment.
Actually, it is part of the original patch: 5a82cd8
There was a problem hiding this comment.
Oof, thanks for digging into it. No preference either way here. Ideally we should have CI check for this in the future.
In many local environments, cgroups v1 no longer works, that's why we had --enable-container-mgr. Now, with crictl patches reverted, we have to --disable-runner-cgroup by default, otherwise local environment doesn't work. Signed-off-by: Oleg Vasilev <[email protected]>
This reverts commit d30687b. Signed-off-by: Oleg Vasilev <[email protected]>
…tart (#749)" This reverts commit 7f17032. Signed-off-by: Oleg Vasilev <[email protected]>
Signed-off-by: Oleg Vasilev <[email protected]>
Omrigan
force-pushed
the
oleg/revert-crictl
branch
from
a7fbb7a to
f1deb9d
Compare
sharnoff
approved these changes
Oct 1, 2024
Merging this branch will decrease overall coverage
Coverage by fileChanged files (no unit tests)
Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code. Changed unit test files
HTML Report |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We decided to go another route, and disable outer cgroup altogether in favor of something better.
Closes https://github.com/neondatabase/cloud/issues/13266.